dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(parser): lex JSXText with memchr (#2558)

Browse source 
Lexing JSXText only requires searching for 2 possible characters (`<`
and `{`), so can use `memchr`.
This commit is contained in:
overlookmotel 2024-03-01 14:26:53 +00:00 committed by GitHub
parent f00834d0fd
commit 78f8c2ce7f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
crates/oxc_parser/src/lexer/jsx.rs
View file

@ -1,7 +1,7 @@
use super::{Kind, Lexer, Token}; use super::{Kind, Lexer, Token};
use crate::diagnostics; use crate::diagnostics;
use memchr::memchr; use memchr::{memchr, memchr2};
use oxc_syntax::identifier::{is_identifier_part, is_identifier_start}; use oxc_syntax::identifier::{is_identifier_part, is_identifier_start};
impl<'a> Lexer<'a> { impl<'a> Lexer<'a> {
@ -71,17 +71,18 @@ impl<'a> Lexer<'a> {
Kind::LCurly Kind::LCurly
} }
Some(_) => { Some(_) => {
loop { // The tokens `{`, `<`, `>` and `}` cannot appear in JSX text.
// The tokens `{`, `<`, `>` and `}` cannot appear in a jsx text. // The TypeScript compiler raises the error "Unexpected token. Did you mean `{'>'}` or `&gt;`?".
// The TypeScript compiler raises the error "Unexpected token. Did you mean `{'>'}` or `&gt;`?". // Where as the Babel compiler does not raise any errors.
// Where as the Babel compiler does not raise any errors. // The following check omits `>` and `}` so that more Babel tests can be passed.
// The following check omits `>` and `}` so that more Babel tests can be passed. let len = memchr2(b'{', b'<', self.remaining().as_bytes());
if self.peek().is_some_and(|c| c == '{' || c == '<') { if let Some(len) = len {
break; // SAFETY: `memchr2` guarantees `len` will be offset from current position
} // of a `{` or `<` byte. So must be a valid UTF-8 boundary, and within bounds of source.
if self.next_char().is_none() { let end = unsafe { self.source.position().add(len) };
break; self.source.set_position(end);
} } else {
self.source.advance_to_end();
} }
Kind::JSXText Kind::JSXText
} }