dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer): always create valid identifiers (#2131)

Browse source 
I'm not familiar with the transformer, so not 100% sure what this
function does. But from the name `create_valid_identifier`, I'm guessing
that `-` is a mistake - it's not a valid character to have in
identifiers.

If I've misunderstood, please feel free to close this.
This commit is contained in:
overlookmotel 2024-01-23 04:35:41 +00:00 committed by GitHub
parent 71173a9181
commit 777352e2ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/es2015/function_name.rs
View file

@ -162,7 +162,7 @@ fn create_valid_identifier(
// }
let id = Atom::from(
atom.chars().map(|c| if is_identifier_part(c) { c } else { '-' }).collect::<String>(),
atom.chars().map(|c| if is_identifier_part(c) { c } else { '_' }).collect::<String>(),
);
let id = if id == "" {