dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer): methods only take &TraverseCtx where possible (#6812)

Browse source 
Methods which only need an immutable ref `&TraverseCtx` take that, instead of unnecessary `&mut TraverseCtx`.
This commit is contained in:
overlookmotel 2024-10-23 11:37:27 +00:00
parent 47bc36832c
commit 759710aa66
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/common/module_imports.rs
View file

@ -193,7 +193,7 @@ impl<'a> ModuleImportsStore<'a> {
fn get_import( fn get_import(
source: Atom<'a>, source: Atom<'a>,
names: Vec<Import<'a>>, names: Vec<Import<'a>>,
ctx: &mut TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) -> Statement<'a> { ) -> Statement<'a> {
let specifiers = ctx.ast.vec_from_iter(names.into_iter().map(|import| match import { let specifiers = ctx.ast.vec_from_iter(names.into_iter().map(|import| match import {
Import::Named(import) => { Import::Named(import) => {

6
crates/oxc_transformer/src/common/var_declarations.rs
View file

@ -72,7 +72,7 @@ impl<'a> VarDeclarationsStore<'a> {
&self, &self,
binding: &BoundIdentifier<'a>, binding: &BoundIdentifier<'a>,
init: Option<Expression<'a>>, init: Option<Expression<'a>>,
ctx: &mut TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) { ) {
let ident = binding.create_binding_identifier(ctx); let ident = binding.create_binding_identifier(ctx);
let ident = ctx.ast.binding_pattern_kind_from_binding_identifier(ident); let ident = ctx.ast.binding_pattern_kind_from_binding_identifier(ident);
@ -86,7 +86,7 @@ impl<'a> VarDeclarationsStore<'a> {
&self, &self,
ident: BindingPattern<'a>, ident: BindingPattern<'a>,
init: Option<Expression<'a>>, init: Option<Expression<'a>>,
ctx: &mut TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) { ) {
let declarator = let declarator =
ctx.ast.variable_declarator(SPAN, VariableDeclarationKind::Var, ident, init, false); ctx.ast.variable_declarator(SPAN, VariableDeclarationKind::Var, ident, init, false);
@ -94,7 +94,7 @@ impl<'a> VarDeclarationsStore<'a> {
} }
/// Add a `VariableDeclarator` to be inserted at top of current enclosing statement block. /// Add a `VariableDeclarator` to be inserted at top of current enclosing statement block.
pub fn insert_declarator(&self, declarator: VariableDeclarator<'a>, ctx: &mut TraverseCtx<'a>) { pub fn insert_declarator(&self, declarator: VariableDeclarator<'a>, ctx: &TraverseCtx<'a>) {
let mut stack = self.stack.borrow_mut(); let mut stack = self.stack.borrow_mut();
stack.last_mut_or_init(|| ctx.ast.vec()).push(declarator); stack.last_mut_or_init(|| ctx.ast.vec()).push(declarator);
} }

2
crates/oxc_transformer/src/es2015/arrow_functions.rs
View file

@ -407,7 +407,7 @@ impl<'a> ArrowFunctions<'a> {
&mut self, &mut self,
statements: &mut Vec<'a, Statement<'a>>, statements: &mut Vec<'a, Statement<'a>>,
this_var: &BoundIdentifier<'a>, this_var: &BoundIdentifier<'a>,
ctx: &mut TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) { ) {
let binding_pattern = ctx.ast.binding_pattern( let binding_pattern = ctx.ast.binding_pattern(
ctx.ast.binding_pattern_kind_from_binding_identifier( ctx.ast.binding_pattern_kind_from_binding_identifier(

2
crates/oxc_transformer/src/react/jsx_source.rs
View file

@ -201,7 +201,7 @@ impl<'a, 'ctx> ReactJsxSource<'a, 'ctx> {
pub fn get_filename_var_declarator( pub fn get_filename_var_declarator(
&self, &self,
ctx: &mut TraverseCtx<'a>, ctx: &TraverseCtx<'a>,
) -> Option<VariableDeclarator<'a>> { ) -> Option<VariableDeclarator<'a>> {
let filename_var = self.filename_var.as_ref()?; let filename_var = self.filename_var.as_ref()?;