dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/eslint): drop quotes around max-params lint warning (#4608)

Browse source 
This was introduced by the diagnostic codes in lint rules 7a75e0f8a7.

---

Checked the rest of the codebase and haven't found other issues.
This commit is contained in:
Jelle van der Waa 2024-08-02 11:36:08 +02:00 committed by GitHub
parent f39e759a53
commit 74fa75aa87
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_linter/src/rules/eslint/max_params.rs
View file

@ -7,7 +7,7 @@ use serde_json::Value;
use crate::{context::LintContext, rule::Rule, AstNode};
fn max_params_diagnostic(x0: &str, span1: Span) -> OxcDiagnostic {
OxcDiagnostic::warn(format!("{x0:?}"))
OxcDiagnostic::warn(x0.to_string())
.with_help(
"This rule enforces a maximum number of parameters allowed in function definitions.",
)

20
crates/oxc_linter/src/snapshots/max_params.snap
View file

@ -1,70 +1,70 @@
---
source: crates/oxc_linter/src/tester.rs
---
⚠ eslint(max-params): "Function 'test' has too many parameters (3). Maximum allowed is 2."
⚠ eslint(max-params): Function 'test' has too many parameters (3). Maximum allowed is 2.
╭─[max_params.tsx:1:14]
1 │ function test(a, b, c) {}
· ─────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (4). Maximum allowed is 3."
⚠ eslint(max-params): Function 'test' has too many parameters (4). Maximum allowed is 3.
╭─[max_params.tsx:1:14]
1 │ function test(a, b, c, d) {}
· ────────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function has too many parameters (4). Maximum allowed is 3."
⚠ eslint(max-params): Function has too many parameters (4). Maximum allowed is 3.
╭─[max_params.tsx:1:20]
1 │ var test = function(a, b, c, d) {};
· ────────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Arrow function has too many parameters (4). Maximum allowed is 3."
⚠ eslint(max-params): Arrow function has too many parameters (4). Maximum allowed is 3.
╭─[max_params.tsx:1:12]
1 │ var test = (a, b, c, d) => {};
· ────────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function has too many parameters (4). Maximum allowed is 3."
⚠ eslint(max-params): Function has too many parameters (4). Maximum allowed is 3.
╭─[max_params.tsx:1:10]
1 │ (function(a, b, c, d) {});
· ────────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (3). Maximum allowed is 1."
⚠ eslint(max-params): Function 'test' has too many parameters (3). Maximum allowed is 1.
╭─[max_params.tsx:1:25]
1 │ var test = function test(a, b, c) {};
· ─────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (3). Maximum allowed is 2."
⚠ eslint(max-params): Function 'test' has too many parameters (3). Maximum allowed is 2.
╭─[max_params.tsx:1:14]
1 │ function test(a, b, c) {}
· ─────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (4). Maximum allowed is 3."
⚠ eslint(max-params): Function 'test' has too many parameters (4). Maximum allowed is 3.
╭─[max_params.tsx:1:14]
1 │ function test(a, b, c, d) {}
· ────────────
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (1). Maximum allowed is 0."
⚠ eslint(max-params): Function 'test' has too many parameters (1). Maximum allowed is 0.
╭─[max_params.tsx:1:14]
1 │ function test(a) {}
· ───
╰────
help: This rule enforces a maximum number of parameters allowed in function definitions.
⚠ eslint(max-params): "Function 'test' has too many parameters (3). Maximum allowed is 2."
⚠ eslint(max-params): Function 'test' has too many parameters (3). Maximum allowed is 2.
╭─[max_params.tsx:1:14]
1 │ function test(a, b, c) {
· ─────────