dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(codegen): add CodeBuffer::as_bytes method (#6498)

Browse source 
`as_bytes` is clearer than `as_ref` (what kind of ref?)
This commit is contained in:
overlookmotel 2024-10-13 10:05:10 +00:00
parent d816b0bd0e
commit 74206204dd
2 changed files with 20 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
crates/oxc_codegen/src/code_buffer.rs
View file

@ -311,6 +311,20 @@ impl CodeBuffer {
self.buf.extend(bytes); self.buf.extend(bytes);
} }
/// Get contents of `CodeBuffer` as a byte slice.
///
/// # Examples
/// ```
/// use oxc_codegen::CodeBuffer;
/// let mut code = CodeBuffer::new();
/// code.print_str("foo");
/// assert_eq!(code.as_bytes(), &[b'f', b'o', b'o']);
/// ```
#[inline]
pub fn as_bytes(&self) -> &[u8] {
&self.buf
}
/// Convert a `CodeBuffer` into a string of source code, leaving its /// Convert a `CodeBuffer` into a string of source code, leaving its
/// internal buffer empty and finalizing the codegen process. /// internal buffer empty and finalizing the codegen process.
/// ///
@ -344,7 +358,7 @@ impl CodeBuffer {
impl AsRef<[u8]> for CodeBuffer { impl AsRef<[u8]> for CodeBuffer {
fn as_ref(&self) -> &[u8] { fn as_ref(&self) -> &[u8] {
&self.buf self.as_bytes()
} }
} }
@ -394,7 +408,7 @@ mod test {
assert!(code.is_empty()); assert!(code.is_empty());
assert_eq!(code.len(), 0); assert_eq!(code.len(), 0);
let empty_slice: &[u8] = &[]; let empty_slice: &[u8] = &[];
assert_eq!(code.as_ref(), empty_slice); assert_eq!(code.as_bytes(), empty_slice);
assert_eq!(String::from(code), ""); assert_eq!(String::from(code), "");
} }
@ -407,7 +421,7 @@ mod test {
code.print_ascii_byte(b'o'); code.print_ascii_byte(b'o');
assert_eq!(code.len(), 3); assert_eq!(code.len(), 3);
assert_eq!(code.as_ref(), &[b'f', b'o', b'o']); assert_eq!(code.as_bytes(), &[b'f', b'o', b'o']);
assert_eq!(String::from(code), "foo"); assert_eq!(String::from(code), "foo");
} }
@ -423,7 +437,7 @@ mod test {
} }
assert_eq!(code.len(), 3); assert_eq!(code.len(), 3);
assert_eq!(code.as_ref(), &[b'f', b'o', b'o']); assert_eq!(code.as_bytes(), &[b'f', b'o', b'o']);
assert_eq!(String::from(code), "foo"); assert_eq!(String::from(code), "foo");
} }

4
crates/oxc_codegen/src/lib.rs
View file

@ -556,13 +556,13 @@ impl<'a> Codegen<'a> {
fn add_source_mapping(&mut self, position: u32) { fn add_source_mapping(&mut self, position: u32) {
if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() { if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() {
sourcemap_builder.add_source_mapping(self.code.as_ref(), position, None); sourcemap_builder.add_source_mapping(self.code.as_bytes(), position, None);
} }
} }
fn add_source_mapping_for_name(&mut self, span: Span, name: &str) { fn add_source_mapping_for_name(&mut self, span: Span, name: &str) {
if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() { if let Some(sourcemap_builder) = self.sourcemap_builder.as_mut() {
sourcemap_builder.add_source_mapping_for_name(self.code.as_ref(), span, name); sourcemap_builder.add_source_mapping_for_name(self.code.as_bytes(), span, name);
} }
} }
} }