dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(ast)!: reduce byte size of TSImportType::attributes by Boxing it (#5678)

Browse source
This commit is contained in:
Boshen 2024-09-10 14:07:51 +00:00
parent ee4fb42d70
commit 7415e85764
5 changed files with 34 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_ast/src/ast/ts.rs
View file

@ -1132,7 +1132,7 @@ pub struct TSImportType<'a> {
pub is_type_of: bool, // `typeof import("foo")` pub is_type_of: bool, // `typeof import("foo")`
pub parameter: TSType<'a>, pub parameter: TSType<'a>,
pub qualifier: Option<TSTypeName<'a>>, pub qualifier: Option<TSTypeName<'a>>,
pub attributes: Option<TSImportAttributes<'a>>, pub attributes: Option<Box<'a, TSImportAttributes<'a>>>,
pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>, pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
} }

8
crates/oxc_ast/src/generated/assert_layouts.rs
View file

@ -1134,14 +1134,14 @@ const _: () = {
assert!(size_of::<TSTypeQueryExprName>() == 16usize); assert!(size_of::<TSTypeQueryExprName>() == 16usize);
assert!(align_of::<TSTypeQueryExprName>() == 8usize); assert!(align_of::<TSTypeQueryExprName>() == 8usize);
assert!(size_of::<TSImportType>() == 120usize); assert!(size_of::<TSImportType>() == 64usize);
assert!(align_of::<TSImportType>() == 8usize); assert!(align_of::<TSImportType>() == 8usize);
assert!(offset_of!(TSImportType, span) == 0usize); assert!(offset_of!(TSImportType, span) == 0usize);
assert!(offset_of!(TSImportType, is_type_of) == 8usize); assert!(offset_of!(TSImportType, is_type_of) == 8usize);
assert!(offset_of!(TSImportType, parameter) == 16usize); assert!(offset_of!(TSImportType, parameter) == 16usize);
assert!(offset_of!(TSImportType, qualifier) == 32usize); assert!(offset_of!(TSImportType, qualifier) == 32usize);
assert!(offset_of!(TSImportType, attributes) == 48usize); assert!(offset_of!(TSImportType, attributes) == 48usize);
assert!(offset_of!(TSImportType, type_parameters) == 112usize); assert!(offset_of!(TSImportType, type_parameters) == 56usize);
assert!(size_of::<TSImportAttributes>() == 64usize); assert!(size_of::<TSImportAttributes>() == 64usize);
assert!(align_of::<TSImportAttributes>() == 8usize); assert!(align_of::<TSImportAttributes>() == 8usize);
@ -2689,14 +2689,14 @@ const _: () = {
assert!(size_of::<TSTypeQueryExprName>() == 8usize); assert!(size_of::<TSTypeQueryExprName>() == 8usize);
assert!(align_of::<TSTypeQueryExprName>() == 4usize); assert!(align_of::<TSTypeQueryExprName>() == 4usize);
assert!(size_of::<TSImportType>() == 72usize); assert!(size_of::<TSImportType>() == 36usize);
assert!(align_of::<TSImportType>() == 4usize); assert!(align_of::<TSImportType>() == 4usize);
assert!(offset_of!(TSImportType, span) == 0usize); assert!(offset_of!(TSImportType, span) == 0usize);
assert!(offset_of!(TSImportType, is_type_of) == 8usize); assert!(offset_of!(TSImportType, is_type_of) == 8usize);
assert!(offset_of!(TSImportType, parameter) == 12usize); assert!(offset_of!(TSImportType, parameter) == 12usize);
assert!(offset_of!(TSImportType, qualifier) == 20usize); assert!(offset_of!(TSImportType, qualifier) == 20usize);
assert!(offset_of!(TSImportType, attributes) == 28usize); assert!(offset_of!(TSImportType, attributes) == 28usize);
assert!(offset_of!(TSImportType, type_parameters) == 68usize); assert!(offset_of!(TSImportType, type_parameters) == 32usize);
assert!(size_of::<TSImportAttributes>() == 40usize); assert!(size_of::<TSImportAttributes>() == 40usize);
assert!(align_of::<TSImportAttributes>() == 4usize); assert!(align_of::<TSImportAttributes>() == 4usize);

38
crates/oxc_ast/src/generated/ast_builder.rs
View file

@ -8845,17 +8845,18 @@ impl<'a> AstBuilder<'a> {
/// - attributes /// - attributes
/// - type_parameters /// - type_parameters
#[inline] #[inline]
pub fn ts_type_import_type<T1>( pub fn ts_type_import_type<T1, T2>(
self, self,
span: Span, span: Span,
is_type_of: bool, is_type_of: bool,
parameter: TSType<'a>, parameter: TSType<'a>,
qualifier: Option<TSTypeName<'a>>, qualifier: Option<TSTypeName<'a>>,
attributes: Option<TSImportAttributes<'a>>, attributes: T1,
type_parameters: T1, type_parameters: T2,
) -> TSType<'a> ) -> TSType<'a>
where where
T1: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>, T1: IntoIn<'a, Option<Box<'a, TSImportAttributes<'a>>>>,
T2: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>,
{ {
TSType::TSImportType(self.alloc(self.ts_import_type( TSType::TSImportType(self.alloc(self.ts_import_type(
span, span,
@ -11696,17 +11697,18 @@ impl<'a> AstBuilder<'a> {
/// - attributes /// - attributes
/// - type_parameters /// - type_parameters
#[inline] #[inline]
pub fn ts_type_query_expr_name_import_type<T1>( pub fn ts_type_query_expr_name_import_type<T1, T2>(
self, self,
span: Span, span: Span,
is_type_of: bool, is_type_of: bool,
parameter: TSType<'a>, parameter: TSType<'a>,
qualifier: Option<TSTypeName<'a>>, qualifier: Option<TSTypeName<'a>>,
attributes: Option<TSImportAttributes<'a>>, attributes: T1,
type_parameters: T1, type_parameters: T2,
) -> TSTypeQueryExprName<'a> ) -> TSTypeQueryExprName<'a>
where where
T1: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>, T1: IntoIn<'a, Option<Box<'a, TSImportAttributes<'a>>>>,
T2: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>,
{ {
TSTypeQueryExprName::TSImportType(self.alloc(self.ts_import_type( TSTypeQueryExprName::TSImportType(self.alloc(self.ts_import_type(
span, span,
@ -11747,24 +11749,25 @@ impl<'a> AstBuilder<'a> {
/// - attributes /// - attributes
/// - type_parameters /// - type_parameters
#[inline] #[inline]
pub fn ts_import_type<T1>( pub fn ts_import_type<T1, T2>(
self, self,
span: Span, span: Span,
is_type_of: bool, is_type_of: bool,
parameter: TSType<'a>, parameter: TSType<'a>,
qualifier: Option<TSTypeName<'a>>, qualifier: Option<TSTypeName<'a>>,
attributes: Option<TSImportAttributes<'a>>, attributes: T1,
type_parameters: T1, type_parameters: T2,
) -> TSImportType<'a> ) -> TSImportType<'a>
where where
T1: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>, T1: IntoIn<'a, Option<Box<'a, TSImportAttributes<'a>>>>,
T2: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>,
{ {
TSImportType { TSImportType {
span, span,
is_type_of, is_type_of,
parameter, parameter,
qualifier, qualifier,
attributes, attributes: attributes.into_in(self.allocator),
type_parameters: type_parameters.into_in(self.allocator), type_parameters: type_parameters.into_in(self.allocator),
} }
} }
@ -11781,17 +11784,18 @@ impl<'a> AstBuilder<'a> {
/// - attributes /// - attributes
/// - type_parameters /// - type_parameters
#[inline] #[inline]
pub fn alloc_ts_import_type<T1>( pub fn alloc_ts_import_type<T1, T2>(
self, self,
span: Span, span: Span,
is_type_of: bool, is_type_of: bool,
parameter: TSType<'a>, parameter: TSType<'a>,
qualifier: Option<TSTypeName<'a>>, qualifier: Option<TSTypeName<'a>>,
attributes: Option<TSImportAttributes<'a>>, attributes: T1,
type_parameters: T1, type_parameters: T2,
) -> Box<'a, TSImportType<'a>> ) -> Box<'a, TSImportType<'a>>
where where
T1: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>, T1: IntoIn<'a, Option<Box<'a, TSImportAttributes<'a>>>>,
T2: IntoIn<'a, Option<Box<'a, TSTypeParameterInstantiation<'a>>>>,
{ {
Box::new_in( Box::new_in(
self.ts_import_type( self.ts_import_type(

12
crates/oxc_traverse/src/generated/ancestor.rs
View file

@ -11914,10 +11914,10 @@ impl<'a, 't> TSImportTypeWithoutParameter<'a, 't> {
} }
#[inline] #[inline]
pub fn attributes(self) -> &'t Option<TSImportAttributes<'a>> { pub fn attributes(self) -> &'t Option<Box<'a, TSImportAttributes<'a>>> {
unsafe { unsafe {
&*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES) &*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES)
as *const Option<TSImportAttributes<'a>>) as *const Option<Box<'a, TSImportAttributes<'a>>>)
} }
} }
@ -11956,10 +11956,10 @@ impl<'a, 't> TSImportTypeWithoutQualifier<'a, 't> {
} }
#[inline] #[inline]
pub fn attributes(self) -> &'t Option<TSImportAttributes<'a>> { pub fn attributes(self) -> &'t Option<Box<'a, TSImportAttributes<'a>>> {
unsafe { unsafe {
&*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES) &*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES)
as *const Option<TSImportAttributes<'a>>) as *const Option<Box<'a, TSImportAttributes<'a>>>)
} }
} }
@ -12048,10 +12048,10 @@ impl<'a, 't> TSImportTypeWithoutTypeParameters<'a, 't> {
} }
#[inline] #[inline]
pub fn attributes(self) -> &'t Option<TSImportAttributes<'a>> { pub fn attributes(self) -> &'t Option<Box<'a, TSImportAttributes<'a>>> {
unsafe { unsafe {
&*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES) &*((self.0 as *const u8).add(OFFSET_TS_IMPORT_TYPE_ATTRIBUTES)
as *const Option<TSImportAttributes<'a>>) as *const Option<Box<'a, TSImportAttributes<'a>>>)
} }
} }
} }

4
crates/oxc_traverse/src/generated/walk.rs
View file

@ -5139,10 +5139,10 @@ pub(crate) unsafe fn walk_ts_import_type<'a, Tr: Traverse<'a>>(
walk_ts_type_name(traverser, field as *mut _, ctx); walk_ts_type_name(traverser, field as *mut _, ctx);
} }
if let Some(field) = &mut *((node as *mut u8).add(ancestor::OFFSET_TS_IMPORT_TYPE_ATTRIBUTES) if let Some(field) = &mut *((node as *mut u8).add(ancestor::OFFSET_TS_IMPORT_TYPE_ATTRIBUTES)
as *mut Option<TSImportAttributes>) as *mut Option<Box<TSImportAttributes>>)
{ {
ctx.retag_stack(AncestorType::TSImportTypeAttributes); ctx.retag_stack(AncestorType::TSImportTypeAttributes);
walk_ts_import_attributes(traverser, field as *mut _, ctx); walk_ts_import_attributes(traverser, (&mut **field) as *mut _, ctx);
} }
if let Some(field) = &mut *((node as *mut u8) if let Some(field) = &mut *((node as *mut u8)
.add(ancestor::OFFSET_TS_IMPORT_TYPE_TYPE_PARAMETERS) .add(ancestor::OFFSET_TS_IMPORT_TYPE_TYPE_PARAMETERS)