dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter) remove parsing of extends eslint config (#1695)

Browse source 
See https://github.com/oxc-project/oxc/issues/1672

we can bring this back (or a version of it) once we work out how we
want`extends` to work.
This commit is contained in:
Cameron 2023-12-16 12:46:27 +00:00 committed by GitHub
parent 6a90cd4af4
commit 73a655f5b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
crates/oxc_linter/src/config/mod.rs
View file

@ -1,4 +1,7 @@
use std::{collections::HashMap, path::PathBuf};
use std::{
collections::{HashMap, HashSet},
path::PathBuf,
};
pub mod errors;
use oxc_diagnostics::{Error, FailedToOpenFileError, Report};
@ -43,18 +46,9 @@ impl ESLintConfig {
}
};
let extends_hm = match parse_extends(&file) {
Ok(Some(extends_hm)) => {
extends_hm.into_iter().collect::<std::collections::HashSet<_>>()
}
Ok(None) => std::collections::HashSet::new(),
Err(e) => {
return Err(FailedToParseConfigError(vec![Error::new(
FailedToParseConfigJsonError(path.clone(), e.to_string()),
)])
.into());
}
};
// See https://github.com/oxc-project/oxc/issues/1672
let extends_hm: HashSet<&str> = HashSet::new();
let roles_hm = match parse_rules(&file) {
Ok(roles_hm) => roles_hm
.into_iter()
@ -107,6 +101,7 @@ impl ESLintConfig {
}
}
#[allow(unused)]
fn parse_extends(root_json: &Value) -> Result<Option<Vec<&'static str>>, Report> {
let Some(extends) = root_json.get("extends") else {
return Ok(None);