dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer): TypeScriptOptions deserialize should fallback to default (#3012)

Browse source
This commit is contained in:
Boshen 2024-04-17 16:27:50 +08:00 committed by GitHub
parent b72bdcaf96
commit 722d4c2350
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_transformer/src/typescript/mod.rs
View file

@ -16,7 +16,7 @@ use crate::context::Ctx;
use self::{annotations::TypeScriptAnnotations, collector::TypeScriptReferenceCollector}; use self::{annotations::TypeScriptAnnotations, collector::TypeScriptReferenceCollector};
#[derive(Debug, Default, Clone, Deserialize)] #[derive(Debug, Default, Clone, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(default, rename_all = "camelCase")]
pub struct TypeScriptOptions { pub struct TypeScriptOptions {
/// When set to true, the transform will only remove type-only imports (introduced in TypeScript 3.8). /// When set to true, the transform will only remove type-only imports (introduced in TypeScript 3.8).
/// This should only be used if you are using TypeScript >= 3.8. /// This should only be used if you are using TypeScript >= 3.8.

12
tasks/transform_conformance/babel.snap.md
View file

@ -1,4 +1,4 @@
Passed: 140/209 Passed: 148/209
# All Passed: # All Passed:
* babel-plugin-transform-react-jsx-source * babel-plugin-transform-react-jsx-source
@ -17,9 +17,7 @@ Passed: 140/209
* opts/optimizeConstEnums/input.ts * opts/optimizeConstEnums/input.ts
* opts/rewriteImportExtensions/input.ts * opts/rewriteImportExtensions/input.ts
# babel-plugin-transform-typescript (84/139) # babel-plugin-transform-typescript (92/139)
* class/abstract-allowDeclareFields-false/input.ts
* class/abstract-allowDeclareFields-true/input.ts
* class/accessor-allowDeclareFields-false/input.ts * class/accessor-allowDeclareFields-false/input.ts
* class/accessor-allowDeclareFields-true/input.ts * class/accessor-allowDeclareFields-true/input.ts
* class/parameter-properties/input.ts * class/parameter-properties/input.ts
@ -33,7 +31,6 @@ Passed: 140/209
* imports/enum-value/input.ts * imports/enum-value/input.ts
* imports/import=-module/input.ts * imports/import=-module/input.ts
* imports/type-only-export-specifier-2/input.ts * imports/type-only-export-specifier-2/input.ts
* namespace/alias/input.ts
* namespace/ambient-module-nested/input.ts * namespace/ambient-module-nested/input.ts
* namespace/ambient-module-nested-exported/input.ts * namespace/ambient-module-nested-exported/input.ts
* namespace/canonical/input.ts * namespace/canonical/input.ts
@ -42,14 +39,10 @@ Passed: 140/209
* namespace/clobber-export/input.ts * namespace/clobber-export/input.ts
* namespace/clobber-import/input.ts * namespace/clobber-import/input.ts
* namespace/contentious-names/input.ts * namespace/contentious-names/input.ts
* namespace/declare/input.ts
* namespace/declare-global-nested-namespace/input.ts
* namespace/empty-removed/input.ts * namespace/empty-removed/input.ts
* namespace/export/input.ts
* namespace/export-type-only/input.ts * namespace/export-type-only/input.ts
* namespace/module-nested/input.ts * namespace/module-nested/input.ts
* namespace/module-nested-export/input.ts * namespace/module-nested-export/input.ts
* namespace/multiple/input.ts
* namespace/mutable-fail/input.ts * namespace/mutable-fail/input.ts
* namespace/namespace-flag/input.ts * namespace/namespace-flag/input.ts
* namespace/namespace-nested-module/input.ts * namespace/namespace-nested-module/input.ts
@ -59,7 +52,6 @@ Passed: 140/209
* namespace/nested-shorthand/input.ts * namespace/nested-shorthand/input.ts
* namespace/nested-shorthand-export/input.ts * namespace/nested-shorthand-export/input.ts
* namespace/same-name/input.ts * namespace/same-name/input.ts
* namespace/undeclared/input.ts
* optimize-const-enums/custom-values/input.ts * optimize-const-enums/custom-values/input.ts
* optimize-const-enums/custom-values-exported/input.ts * optimize-const-enums/custom-values-exported/input.ts
* optimize-const-enums/declare/input.ts * optimize-const-enums/declare/input.ts

2
tasks/transform_conformance/src/test_case.rs
View file

@ -352,6 +352,8 @@ impl TestCase for ConformanceTestCase {
println!("{output}\n"); println!("{output}\n");
println!("Transformed:\n"); println!("Transformed:\n");
println!("{transformed_code}"); println!("{transformed_code}");
println!("Errors:\n");
println!("{actual_errors}\n");
if !passed { if !passed {
println!("Diff:\n"); println!("Diff:\n");
print_diff_in_terminal(&output, &transformed_code); print_diff_in_terminal(&output, &transformed_code);