dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(parser): restore regex flag parsing (#2007)

Browse source 
As discussed in
https://github.com/oxc-project/oxc/pull/1999#issuecomment-1888916383,
this PR restores some of regex parsing behavior to as it was prior to
#1926.
This commit is contained in:
overlookmotel 2024-01-12 19:19:33 +00:00 committed by GitHub
parent 1ecdeaa662
commit 712e99cf9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/oxc_parser/src/lexer/mod.rs
View file

@ -872,17 +872,17 @@ impl<'a> Lexer<'a> {
self.current.chars.next(); self.current.chars.next();
if !ch.is_ascii_lowercase() { if !ch.is_ascii_lowercase() {
self.error(diagnostics::RegExpFlag(ch, self.current_offset())); self.error(diagnostics::RegExpFlag(ch, self.current_offset()));
break; continue;
} }
let flag = if let Ok(flag) = RegExpFlags::try_from(ch) { let flag = if let Ok(flag) = RegExpFlags::try_from(ch) {
flag flag
} else { } else {
self.error(diagnostics::RegExpFlag(ch, self.current_offset())); self.error(diagnostics::RegExpFlag(ch, self.current_offset()));
break; continue;
}; };
if flags.contains(flag) { if flags.contains(flag) {
self.error(diagnostics::RegExpFlagTwice(ch, self.current_offset())); self.error(diagnostics::RegExpFlagTwice(ch, self.current_offset()));
break; continue;
} }
flags |= flag; flags |= flag;
} }