dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 12:51:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/object-rest-spread): avoid multiple symbol lookups (#7420)

Browse source 
`IdentifierReference::is_global_reference` and `MaybeBoundIdentifier::from_identifier_reference` both look up the symbol for the identifier. Do this lookup only once, rather than twice.
This commit is contained in:
overlookmotel 2024-11-23 05:00:30 +00:00
parent 779f4798e2
commit 6fd0fcb4ff
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_transformer/src/es2018/object_rest_spread.rs
View file

@ -35,7 +35,7 @@ use oxc_allocator::{CloneIn, GetAddress, Vec as ArenaVec};
use oxc_ast::{ast::*, NONE}; use oxc_ast::{ast::*, NONE};
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_ecmascript::{BoundNames, ToJsString}; use oxc_ecmascript::{BoundNames, ToJsString};
use oxc_semantic::{IsGlobalReference, ScopeFlags, ScopeId, SymbolFlags}; use oxc_semantic::{ScopeFlags, ScopeId, SymbolFlags};
use oxc_span::{GetSpan, SPAN}; use oxc_span::{GetSpan, SPAN};
use oxc_traverse::{Ancestor, MaybeBoundIdentifier, Traverse, TraverseCtx}; use oxc_traverse::{Ancestor, MaybeBoundIdentifier, Traverse, TraverseCtx};
@ -998,9 +998,9 @@ impl<'a, 'ctx> ObjectRestSpread<'a, 'ctx> {
} }
*all_primitives = false; *all_primitives = false;
if let Expression::Identifier(ident) = expr { if let Expression::Identifier(ident) = expr {
if !ident.is_global_reference(ctx.symbols()) { let binding = MaybeBoundIdentifier::from_identifier_reference(ident, ctx);
let expr = MaybeBoundIdentifier::from_identifier_reference(ident, ctx) if let Some(binding) = binding.to_bound_identifier() {
.create_read_expression(ctx); let expr = binding.create_read_expression(ctx);
return Some(ArrayExpressionElement::from(expr)); return Some(ArrayExpressionElement::from(expr));
} }
} }