dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/class-properties): pass BoundIdentifiers by reference (#7968)

Browse source 
Don't pass by value when passing by reference is sufficient.
This commit is contained in:
overlookmotel 2024-12-17 16:34:09 +00:00
parent 69eeeea138
commit 6fc40f030e
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_transformer/src/es2022/class_properties/private_field.rs
View file

@ -389,14 +389,14 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
self.transform_static_assignment_expression(
expr,
prop_binding,
class_binding,
&prop_binding,
&class_binding,
class_symbol_id,
is_declaration,
ctx,
);
} else {
self.transform_instance_assignment_expression(expr, prop_binding, ctx);
self.transform_instance_assignment_expression(expr, &prop_binding, ctx);
}
}
@ -416,12 +416,11 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
// `AssignmentTarget::PrivateFieldExpression` on left, and that clones in
// `transform_assignment_expression` can be elided.
#[inline]
#[expect(clippy::needless_pass_by_value)]
fn transform_static_assignment_expression(
&self,
expr: &mut Expression<'a>,
prop_binding: BoundIdentifier<'a>,
class_binding: BoundIdentifier<'a>,
prop_binding: &BoundIdentifier<'a>,
class_binding: &BoundIdentifier<'a>,
class_symbol_id: Option<SymbolId>,
is_declaration: bool,
ctx: &mut TraverseCtx<'a>,
@ -575,11 +574,10 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
// `AssignmentTarget::PrivateFieldExpression` on left, and that clones in
// `transform_assignment_expression` can be elided.
#[inline]
#[expect(clippy::needless_pass_by_value)]
fn transform_instance_assignment_expression(
&self,
expr: &mut Expression<'a>,
prop_binding: BoundIdentifier<'a>,
prop_binding: &BoundIdentifier<'a>,
ctx: &mut TraverseCtx<'a>,
) {
let assign_expr = match ctx.ast.move_expression(expr) {