From 6f270f1198391b751c346cb3388d3e9ee243c052 Mon Sep 17 00:00:00 2001
From: Boshen <boshenc@gmail.com>
Date: Sun, 3 Sep 2023 10:19:27 +0800
Subject: [PATCH] perf(linter): swap the order of checks for no_caller (#844)

---
 crates/oxc_linter/src/rules/eslint/no_caller.rs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/crates/oxc_linter/src/rules/eslint/no_caller.rs b/crates/oxc_linter/src/rules/eslint/no_caller.rs
index 3df206409..2690bfccc 100644
--- a/crates/oxc_linter/src/rules/eslint/no_caller.rs
+++ b/crates/oxc_linter/src/rules/eslint/no_caller.rs
@@ -51,14 +51,14 @@ declare_oxc_lint!(
 
 impl Rule for NoCaller {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
-        let AstKind::MemberExpression(MemberExpression::StaticMemberExpression(expr)) = node.kind()
-        else {
-            return;
-        };
-        if expr.object.is_specific_id("arguments")
-            && (expr.property.name == "callee" || expr.property.name == "caller")
+        if let AstKind::MemberExpression(MemberExpression::StaticMemberExpression(expr)) =
+            node.kind()
         {
-            ctx.diagnostic(NoCallerDiagnostic(expr.property.span));
+            if (expr.property.name == "callee" || expr.property.name == "caller")
+                && expr.object.is_specific_id("arguments")
+            {
+                ctx.diagnostic(NoCallerDiagnostic(expr.property.span));
+            }
         }
     }
 }