dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(vscode): incorrect diagnostic position (#2461)

Browse source 
fix: #2456
This commit is contained in:
Dunqing 2024-02-21 12:11:16 +08:00 committed by GitHub
parent e7ce633d8c
commit 65571d73a7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_language_server/src/linter.rs
View file

@ -369,8 +369,10 @@ fn get_valid_extensions() -> Vec<&'static str> {
#[allow(clippy::cast_possible_truncation)]
fn offset_to_position(offset: usize, source_text: &str) -> Option<Position> {
let rope = Rope::from_str(source_text);
let line = rope.try_char_to_line(offset).ok()?;
let line = rope.try_byte_to_line(offset).ok()?;
let first_char_of_line = rope.try_line_to_char(line).ok()?;
// Original offset is byte, but Rope uses char offset
let offset = rope.try_byte_to_char(offset).ok()?;
let column = offset - first_char_of_line;
Some(Position::new(line as u32, column as u32))
}