From 63a66cfff3cd8c88b71e96674114eafb544b9ce3 Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Fri, 29 Nov 2024 08:10:07 +0000 Subject: [PATCH] refactor(minifier): remove unused ast pass from DCE (#7540) --- crates/oxc_minifier/examples/minifier.rs | 2 +- crates/oxc_minifier/src/compressor.rs | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/oxc_minifier/examples/minifier.rs b/crates/oxc_minifier/examples/minifier.rs index 80bbfe786..76c30e3a4 100644 --- a/crates/oxc_minifier/examples/minifier.rs +++ b/crates/oxc_minifier/examples/minifier.rs @@ -47,7 +47,7 @@ fn minify( ) -> String { let ret = Parser::new(allocator, source_text, source_type).parse(); let mut program = ret.program; - let options = MinifierOptions { mangle, compress: CompressOptions::dead_code_elimination() }; + let options = MinifierOptions { mangle, compress: CompressOptions::default() }; let ret = Minifier::new(options).build(allocator, &mut program); CodeGenerator::new() .with_options(CodegenOptions { minify: nospace, ..CodegenOptions::default() }) diff --git a/crates/oxc_minifier/src/compressor.rs b/crates/oxc_minifier/src/compressor.rs index c5d72fc7b..a746093bd 100644 --- a/crates/oxc_minifier/src/compressor.rs +++ b/crates/oxc_minifier/src/compressor.rs @@ -5,8 +5,8 @@ use oxc_traverse::ReusableTraverseCtx; use crate::{ ast_passes::{ - CollapsePass, LatePeepholeOptimizations, PeepholeFoldConstants, PeepholeMinimizeConditions, - PeepholeOptimizations, PeepholeRemoveDeadCode, RemoveSyntax, + CollapsePass, LatePeepholeOptimizations, PeepholeFoldConstants, PeepholeOptimizations, + PeepholeRemoveDeadCode, RemoveSyntax, }, CompressOptions, CompressorPass, }; @@ -49,7 +49,6 @@ impl<'a> Compressor<'a> { fn dead_code_elimination(program: &mut Program<'a>, ctx: &mut ReusableTraverseCtx<'a>) { PeepholeFoldConstants::new().build(program, ctx); - PeepholeMinimizeConditions::new().build(program, ctx); PeepholeRemoveDeadCode::new().build(program, ctx); } }