dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(minifier): handle arrow fn expressions correctly in is_in_boolean_context (#8260)

Browse source 
`var k = () => !!x` was incorrectly being minified to `var k = () => x`
This commit is contained in:
camc314 2025-01-06 02:21:25 +00:00
parent 7f19211736
commit 62a2644e07
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_minifier/src/ast_passes/peephole_minimize_conditions.rs
View file

@ -480,15 +480,24 @@ impl<'a> PeepholeMinimizeConditions {
// inside the `if` stmt, `condition` is coerced to a boolean
// whereas inside the return, it is not
fn is_in_boolean_context(ctx: &mut TraverseCtx<'_>) -> bool {
for ancestor in ctx.ancestors() {
let mut ancestors = ctx.ancestors().peekable();
while let Some(ancestor) = ancestors.next() {
match ancestor {
Ancestor::IfStatementTest(_)
| Ancestor::WhileStatementTest(_)
| Ancestor::ForStatementTest(_)
| Ancestor::DoWhileStatementTest(_)
| Ancestor::ExpressionStatementExpression(_)
| Ancestor::SequenceExpressionExpressions(_)
| Ancestor::ProgramBody(_) => return true,
// `var k = () => foo`, `foo` is not coerced to a boolean
Ancestor::ExpressionStatementExpression(_) => {
if let Some(next_ancestor) = ancestors.peek() {
match next_ancestor {
Ancestor::FunctionBodyStatements(_) => return false,
_ => return true,
}
}
}
Ancestor::CallExpressionArguments(_)
| Ancestor::AssignmentPatternRight(_)
| Ancestor::BindingRestElementArgument(_)
@ -503,6 +512,7 @@ impl<'a> PeepholeMinimizeConditions {
_ => continue,
}
}
true
}
@ -867,6 +877,8 @@ mod test {
fold("foo ? bar : bar", "foo, bar");
fold_same("foo ? bar : baz");
fold("foo() ? bar : bar", "foo(), bar");
test_same("var k = () => !!x;");
}
#[test]