dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(traverse): generate_uid_in_root_scope method (#3611)

Browse source 
Add method on `TraverseCtx` for common case of creating a UID binding in root scope.
This commit is contained in:
overlookmotel 2024-06-11 06:41:12 +00:00
parent 89bcbd5b8d
commit 60cbdece65
4 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/oxc_semantic/src/scope.rs
View file

@ -75,6 +75,7 @@ impl ScopeTree {
self.parent_ids.iter_enumerated().map(|(scope_id, _)| scope_id)
}
#[inline]
pub fn root_scope_id(&self) -> ScopeId {
ScopeId::new(0)
}

6
crates/oxc_transformer/src/react/jsx.rs
View file

@ -118,9 +118,8 @@ impl<'a> AutomaticScriptBindings<'a> {
front: bool,
ctx: &mut TraverseCtx<'a>,
) -> BoundIdentifier<'a> {
let root_scope_id = ctx.scopes().root_scope_id();
let symbol_id =
ctx.generate_uid(variable_name, root_scope_id, SymbolFlags::FunctionScopedVariable);
ctx.generate_uid_in_root_scope(variable_name, SymbolFlags::FunctionScopedVariable);
let variable_name = ctx.ast.new_atom(&ctx.symbols().names[symbol_id]);
let import = NamedImport::new(variable_name.clone(), None, symbol_id);
@ -220,8 +219,7 @@ impl<'a> AutomaticModuleBindings<'a> {
source: Atom<'a>,
ctx: &mut TraverseCtx<'a>,
) -> BoundIdentifier<'a> {
let root_scope_id = ctx.scopes().root_scope_id();
let symbol_id = ctx.generate_uid(name, root_scope_id, SymbolFlags::FunctionScopedVariable);
let symbol_id = ctx.generate_uid_in_root_scope(name, SymbolFlags::FunctionScopedVariable);
let local = ctx.ast.new_atom(&ctx.symbols().names[symbol_id]);
let import = NamedImport::new(Atom::from(name), Some(local.clone()), symbol_id);

7
crates/oxc_traverse/src/context/mod.rs
View file

@ -289,6 +289,13 @@ impl<'a> TraverseCtx<'a> {
self.scoping.generate_uid_in_current_scope(name, flags)
}
/// Generate UID in root scope.
///
/// This is a shortcut for `ctx.scoping.generate_uid_in_root_scope`.
pub fn generate_uid_in_root_scope(&mut self, name: &str, flags: SymbolFlags) -> SymbolId {
self.scoping.generate_uid_in_root_scope(name, flags)
}
/// Create a reference bound to a `SymbolId`.
///
/// This is a shortcut for `ctx.scoping.create_bound_reference`.

5
crates/oxc_traverse/src/context/scoping.rs
View file

@ -185,6 +185,11 @@ impl TraverseScoping {
self.generate_uid(name, self.current_scope_id, flags)
}
/// Generate UID in root scope.
pub fn generate_uid_in_root_scope(&mut self, name: &str, flags: SymbolFlags) -> SymbolId {
self.generate_uid(name, self.scopes.root_scope_id(), flags)
}
/// Create a reference bound to a `SymbolId`
pub fn create_bound_reference(
&mut self,