From 5d6fa259f4414f9c003c5de22446f013b642d64b Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Tue, 10 Dec 2024 02:28:29 +0000
Subject: [PATCH] refactor(traverse)!: remove `TraverseCtx::is_static` (#7760)

`TraverseCtx::is_static` was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method. `TransformCtx::duplicate_expression` fulfills the same role.
---
 crates/oxc_traverse/src/context/mod.rs     | 15 -------------
 crates/oxc_traverse/src/context/scoping.rs | 26 ----------------------
 2 files changed, 41 deletions(-)

diff --git a/crates/oxc_traverse/src/context/mod.rs b/crates/oxc_traverse/src/context/mod.rs
index 710ac8723..293d399df 100644
--- a/crates/oxc_traverse/src/context/mod.rs
+++ b/crates/oxc_traverse/src/context/mod.rs
@@ -589,21 +589,6 @@ impl<'a> TraverseCtx<'a> {
     pub fn delete_reference_for_identifier(&mut self, ident: &IdentifierReference) {
         self.scoping.delete_reference_for_identifier(ident);
     }
-
-    /// Determine whether evaluating the specific input `node` is a consequenceless reference.
-    ///
-    /// i.e. evaluating it won't result in potentially arbitrary code from being run.
-    /// The following are allowed and determined not to cause side effects:
-    ///
-    /// - `this` expressions
-    /// - `super` expressions
-    /// - Bound identifiers which are not mutated
-    ///
-    /// This is a shortcut for `ctx.scoping.is_static`.
-    #[inline]
-    pub fn is_static(&self, expr: &Expression) -> bool {
-        self.scoping.is_static(expr)
-    }
 }
 
 // Methods used internally within crate
diff --git a/crates/oxc_traverse/src/context/scoping.rs b/crates/oxc_traverse/src/context/scoping.rs
index 61bc4c00b..d07a126d3 100644
--- a/crates/oxc_traverse/src/context/scoping.rs
+++ b/crates/oxc_traverse/src/context/scoping.rs
@@ -362,32 +362,6 @@ impl TraverseScoping {
     pub fn delete_reference_for_identifier(&mut self, ident: &IdentifierReference) {
         self.delete_reference(ident.reference_id(), &ident.name);
     }
-
-    /// Determine whether evaluating the specific input `node` is a consequenceless reference.
-    ///
-    /// i.e. evaluating it won't result in potentially arbitrary code from being run.
-    /// The following are allowed and determined not to cause side effects:
-    ///
-    /// - `this` expressions
-    /// - `super` expressions
-    /// - Bound identifiers which are not mutated
-    ///
-    /// Based on Babel's `scope.isStatic` logic.
-    /// <https://github.com/babel/babel/blob/419644f27c5c59deb19e71aaabd417a3bc5483ca/packages/babel-traverse/src/scope/index.ts#L557>
-    #[inline]
-    pub fn is_static(&self, expr: &Expression) -> bool {
-        match expr {
-            Expression::ThisExpression(_) | Expression::Super(_) => true,
-            Expression::Identifier(ident) => {
-                self.symbols.get_reference(ident.reference_id()).symbol_id().is_some_and(
-                    |symbol_id| {
-                        self.symbols.get_resolved_references(symbol_id).all(|r| !r.is_write())
-                    },
-                )
-            }
-            _ => false,
-        }
-    }
 }
 
 // Methods used internally within crate