From 591bee2ba1224415a040b4bb4b0ba50d0c28305b Mon Sep 17 00:00:00 2001 From: Boshen Date: Wed, 31 May 2023 16:41:50 +0800 Subject: [PATCH] chore(linter): update snapshots --- crates/oxc_linter/src/snapshots/array_callback_return.snap | 2 +- .../src/snapshots/bad_array_method_on_arguments.snap | 2 +- crates/oxc_linter/src/snapshots/bad_bitwise_operator.snap | 2 +- crates/oxc_linter/src/snapshots/bad_comparison_sequence.snap | 2 +- crates/oxc_linter/src/snapshots/constructor_super.snap | 2 +- crates/oxc_linter/src/snapshots/eq_eq_eq.snap | 2 +- crates/oxc_linter/src/snapshots/for_direction.snap | 2 +- crates/oxc_linter/src/snapshots/isolated_declaration.snap | 2 +- crates/oxc_linter/src/snapshots/no_array_constructor.snap | 2 +- crates/oxc_linter/src/snapshots/no_async_promise_executor.snap | 2 +- crates/oxc_linter/src/snapshots/no_bitwise.snap | 2 +- crates/oxc_linter/src/snapshots/no_caller.snap | 3 +-- crates/oxc_linter/src/snapshots/no_class_assign.snap | 3 +-- crates/oxc_linter/src/snapshots/no_compare_neg_zero.snap | 3 +-- crates/oxc_linter/src/snapshots/no_const_assign.snap | 2 +- .../src/snapshots/no_constant_binary_expression.snap | 2 +- crates/oxc_linter/src/snapshots/no_constant_condition.snap | 2 +- crates/oxc_linter/src/snapshots/no_debugger.snap | 2 +- crates/oxc_linter/src/snapshots/no_dupe_class_members.snap | 3 +-- crates/oxc_linter/src/snapshots/no_dupe_keys.snap | 2 +- crates/oxc_linter/src/snapshots/no_duplicate_case.snap | 3 +-- crates/oxc_linter/src/snapshots/no_empty.snap | 2 +- crates/oxc_linter/src/snapshots/no_empty_pattern.snap | 2 +- crates/oxc_linter/src/snapshots/no_function_assign.snap | 2 +- crates/oxc_linter/src/snapshots/no_mixed_operators.snap | 2 +- crates/oxc_linter/src/snapshots/no_new_symbol.snap | 2 +- crates/oxc_linter/src/snapshots/no_self_compare.snap | 3 +-- .../oxc_linter/src/snapshots/no_shadow_restricted_names.snap | 2 +- crates/oxc_linter/src/snapshots/no_unsafe_negation.snap | 2 +- crates/oxc_linter/src/snapshots/no_unused_labels.snap | 2 +- crates/oxc_linter/src/snapshots/uninvoked_array_callback.snap | 2 +- crates/oxc_linter/src/snapshots/use_isnan.snap | 3 +-- crates/oxc_linter/src/snapshots/valid_typeof.snap | 2 +- crates/oxc_linter/src/tester.rs | 1 + 34 files changed, 34 insertions(+), 40 deletions(-) diff --git a/crates/oxc_linter/src/snapshots/array_callback_return.snap b/crates/oxc_linter/src/snapshots/array_callback_return.snap index 22288174d..846c35bce 100644 --- a/crates/oxc_linter/src/snapshots/array_callback_return.snap +++ b/crates/oxc_linter/src/snapshots/array_callback_return.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: array_callback_return --- - ⚠ eslint(array-callback-return): Missing return on some path for array method "Array.form" ╭─[array_callback_return.tsx:1:1] 1 │ Array.from(x, function() {}) @@ -793,3 +792,4 @@ expression: array_callback_return ╰──── help: Array method "Array.prototype.filter" needs to have valid return on all code paths + diff --git a/crates/oxc_linter/src/snapshots/bad_array_method_on_arguments.snap b/crates/oxc_linter/src/snapshots/bad_array_method_on_arguments.snap index b70d7b717..f635cb677 100644 --- a/crates/oxc_linter/src/snapshots/bad_array_method_on_arguments.snap +++ b/crates/oxc_linter/src/snapshots/bad_array_method_on_arguments.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: bad_array_method_on_arguments --- - ⚠ Bad array method on arguments ╭─[bad_array_method_on_arguments.tsx:1:1] 1 │ function fn() {arguments['map'](() => {})} @@ -234,3 +233,4 @@ expression: bad_array_method_on_arguments ╰──── help: The 'arguments' object does not have '@@iterator()' method. If an array method was intended, consider converting the 'arguments' object to an array or using ES6 rest parameter instead. + diff --git a/crates/oxc_linter/src/snapshots/bad_bitwise_operator.snap b/crates/oxc_linter/src/snapshots/bad_bitwise_operator.snap index 66d6c4daf..53f43b9d2 100644 --- a/crates/oxc_linter/src/snapshots/bad_bitwise_operator.snap +++ b/crates/oxc_linter/src/snapshots/bad_bitwise_operator.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: bad_bitwise_operator --- - ⚠ Bad bitwise operator ╭─[bad_bitwise_operator.tsx:1:1] 1 │ var a = obj & obj.a @@ -108,3 +107,4 @@ expression: bad_bitwise_operator ╰──── help: Bitwise operator '|=' seems unintended. Consider using non-compound assignment and logical operator '||' instead. + diff --git a/crates/oxc_linter/src/snapshots/bad_comparison_sequence.snap b/crates/oxc_linter/src/snapshots/bad_comparison_sequence.snap index 12f789c20..ba49303fd 100644 --- a/crates/oxc_linter/src/snapshots/bad_comparison_sequence.snap +++ b/crates/oxc_linter/src/snapshots/bad_comparison_sequence.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: bad_comparison_sequence --- - ⚠ Bad comparison sequence ╭─[bad_comparison_sequence.tsx:1:1] 1 │ if (a == b == c) { console.log('foo') } @@ -291,3 +290,4 @@ expression: bad_comparison_sequence help: Comparison result should not be used directly as an operand of another comparison. If you need to compare three or more operands, you should connect each comparison operation with logical AND operator (`&&`) + diff --git a/crates/oxc_linter/src/snapshots/constructor_super.snap b/crates/oxc_linter/src/snapshots/constructor_super.snap index a440e831d..5d8412015 100644 --- a/crates/oxc_linter/src/snapshots/constructor_super.snap +++ b/crates/oxc_linter/src/snapshots/constructor_super.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: constructor_super --- - ⚠ eslint(constructor-super): Expected to call 'super()'. ╭─[constructor_super.tsx:1:1] 1 │ class A extends B { constructor() {} } @@ -44,3 +43,4 @@ expression: constructor_super ╰──── help: Do not call 'super()' from constructor. + diff --git a/crates/oxc_linter/src/snapshots/eq_eq_eq.snap b/crates/oxc_linter/src/snapshots/eq_eq_eq.snap index 575f6d8d4..1493469dd 100644 --- a/crates/oxc_linter/src/snapshots/eq_eq_eq.snap +++ b/crates/oxc_linter/src/snapshots/eq_eq_eq.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: eq_eq_eq --- - ⚠ eslint(eqeqeq): Expected === and instead saw == ╭─[eq_eq_eq.tsx:1:1] 1 │ a == b @@ -31,3 +30,4 @@ expression: eq_eq_eq ╰──── help: Prefer strict === operator + diff --git a/crates/oxc_linter/src/snapshots/for_direction.snap b/crates/oxc_linter/src/snapshots/for_direction.snap index c2330d61e..bba543c19 100644 --- a/crates/oxc_linter/src/snapshots/for_direction.snap +++ b/crates/oxc_linter/src/snapshots/for_direction.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: for_direction --- - ⚠ eslint(for-direction): The update clause in this loop moves the variable in the wrong direction ╭─[for_direction.tsx:1:1] 1 │ for (var i = 0; i < 10; i--){} @@ -111,3 +110,4 @@ expression: for_direction ╰──── help: Use while loop for intended infinite loop + diff --git a/crates/oxc_linter/src/snapshots/isolated_declaration.snap b/crates/oxc_linter/src/snapshots/isolated_declaration.snap index 38afa9d0e..2eaba8efd 100644 --- a/crates/oxc_linter/src/snapshots/isolated_declaration.snap +++ b/crates/oxc_linter/src/snapshots/isolated_declaration.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: isolated_declaration --- - ⚠ isolated-declaration: Requires type annotation on export parameters ╭─[isolated_declaration.tsx:1:1] 1 │ export function foo(a) { return a; } @@ -57,3 +56,4 @@ expression: isolated_declaration · ─── ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_array_constructor.snap b/crates/oxc_linter/src/snapshots/no_array_constructor.snap index ccd4e898a..8f17d1088 100644 --- a/crates/oxc_linter/src/snapshots/no_array_constructor.snap +++ b/crates/oxc_linter/src/snapshots/no_array_constructor.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_array_constructor --- - ⚠ eslint(no-array-constructor): Disallow `Array` constructors ╭─[no_array_constructor.tsx:1:1] 1 │ new Array() @@ -52,3 +51,4 @@ expression: no_array_constructor ╰──── help: Use array literal instead + diff --git a/crates/oxc_linter/src/snapshots/no_async_promise_executor.snap b/crates/oxc_linter/src/snapshots/no_async_promise_executor.snap index e8a29edd6..1492e7690 100644 --- a/crates/oxc_linter/src/snapshots/no_async_promise_executor.snap +++ b/crates/oxc_linter/src/snapshots/no_async_promise_executor.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_async_promise_executor --- - ⚠ eslint(no-async-promise-executor): Promise executor functions should not be `async`. ╭─[no_async_promise_executor.tsx:1:1] 1 │ new Promise(async function foo(resolve, reject) {}) @@ -21,3 +20,4 @@ expression: no_async_promise_executor · ───── ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_bitwise.snap b/crates/oxc_linter/src/snapshots/no_bitwise.snap index 942eedae9..27f164d12 100644 --- a/crates/oxc_linter/src/snapshots/no_bitwise.snap +++ b/crates/oxc_linter/src/snapshots/no_bitwise.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_bitwise --- - ⚠ eslint(no-bitwise): Unexpected use of "^" ╭─[no_bitwise.tsx:1:1] 1 │ a ^ b @@ -94,3 +93,4 @@ expression: no_bitwise ╰──── help: bitwise operators are not allowed, maybe you mistyped `&&` or `||` + diff --git a/crates/oxc_linter/src/snapshots/no_caller.snap b/crates/oxc_linter/src/snapshots/no_caller.snap index 90b0a07a2..f2da3e1b9 100644 --- a/crates/oxc_linter/src/snapshots/no_caller.snap +++ b/crates/oxc_linter/src/snapshots/no_caller.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: no_caller --- - ⚠ eslint(no-caller): Disallow the use of arguments.caller or arguments.callee ╭─[no_caller.tsx:1:1] 1 │ var x = arguments.callee @@ -18,3 +16,4 @@ expression: no_caller ╰──── help: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them + diff --git a/crates/oxc_linter/src/snapshots/no_class_assign.snap b/crates/oxc_linter/src/snapshots/no_class_assign.snap index 5e80bc5db..1c0bc99d7 100644 --- a/crates/oxc_linter/src/snapshots/no_class_assign.snap +++ b/crates/oxc_linter/src/snapshots/no_class_assign.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 67 expression: no_class_assign --- - ⚠ eslint(no-class-assign): Unexpected re-assignment of class A ╭─[no_class_assign.tsx:1:1] 1 │ class A { } A = 0; @@ -76,3 +74,4 @@ expression: no_class_assign · ╰── A is declared as class here ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_compare_neg_zero.snap b/crates/oxc_linter/src/snapshots/no_compare_neg_zero.snap index 59c7ac446..aa76500ea 100644 --- a/crates/oxc_linter/src/snapshots/no_compare_neg_zero.snap +++ b/crates/oxc_linter/src/snapshots/no_compare_neg_zero.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: no_compare_neg_zero --- - ⚠ eslint(no-compare-neg-zero): Do not use the === operator to compare against -0. ╭─[no_compare_neg_zero.tsx:1:1] 1 │ x === -0 @@ -95,3 +93,4 @@ expression: no_compare_neg_zero ╰──── help: Use Object.is(x, -0) to test equality with -0 and use 0 for other cases + diff --git a/crates/oxc_linter/src/snapshots/no_const_assign.snap b/crates/oxc_linter/src/snapshots/no_const_assign.snap index d64c7ddf1..e344ae3f8 100644 --- a/crates/oxc_linter/src/snapshots/no_const_assign.snap +++ b/crates/oxc_linter/src/snapshots/no_const_assign.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_const_assign --- - ⚠ eslint(no-const-assign): Unexpected re-assignment of const variable x ╭─[no_const_assign.tsx:1:1] 1 │ const x = 0; x = 1; @@ -139,3 +138,4 @@ expression: no_const_assign · ╰── b is declared here as const ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_constant_binary_expression.snap b/crates/oxc_linter/src/snapshots/no_constant_binary_expression.snap index e491791ad..234048b52 100644 --- a/crates/oxc_linter/src/snapshots/no_constant_binary_expression.snap +++ b/crates/oxc_linter/src/snapshots/no_constant_binary_expression.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_constant_binary_expression --- - ⚠ eslint(no-constant-binary-expression): Unexpected constant "truthiness" on the left-hand side of a `"&&"` expression ╭─[no_constant_binary_expression.tsx:1:1] 1 │ [] && greeting @@ -1550,3 +1549,4 @@ expression: no_constant_binary_expression · ╰── This expression always evaluates to the constant on the left-hand side ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_constant_condition.snap b/crates/oxc_linter/src/snapshots/no_constant_condition.snap index 3a7a7eb7b..2943b84b6 100644 --- a/crates/oxc_linter/src/snapshots/no_constant_condition.snap +++ b/crates/oxc_linter/src/snapshots/no_constant_condition.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_constant_condition --- - ⚠ eslint(no-constant-condition): Unexpected constant condition ╭─[no_constant_condition.tsx:1:1] 1 │ if(-2); @@ -773,3 +772,4 @@ expression: no_constant_condition ╰──── help: Constant expression as a test condition is not allowed + diff --git a/crates/oxc_linter/src/snapshots/no_debugger.snap b/crates/oxc_linter/src/snapshots/no_debugger.snap index a5a082c49..33fc4bbe2 100644 --- a/crates/oxc_linter/src/snapshots/no_debugger.snap +++ b/crates/oxc_linter/src/snapshots/no_debugger.snap @@ -2,10 +2,10 @@ source: crates/oxc_linter/src/tester.rs expression: no_debugger --- - ⚠ eslint(no-debugger): `debugger` statement is not allowed ╭─[no_debugger.tsx:1:1] 1 │ if (foo) debugger · ──────── ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_dupe_class_members.snap b/crates/oxc_linter/src/snapshots/no_dupe_class_members.snap index 0342590a2..76a0b8350 100644 --- a/crates/oxc_linter/src/snapshots/no_dupe_class_members.snap +++ b/crates/oxc_linter/src/snapshots/no_dupe_class_members.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: no_dupe_class_members --- - ⚠ eslint(no-dupe-class-members): Duplicate class member: "foo" ╭─[no_dupe_class_members.tsx:1:1] 1 │ class A { foo() {} foo() {} } @@ -287,3 +285,4 @@ expression: no_dupe_class_members ╰──── help: The last declaration overwrites previous ones, remove one of them or rename if both should be retained + diff --git a/crates/oxc_linter/src/snapshots/no_dupe_keys.snap b/crates/oxc_linter/src/snapshots/no_dupe_keys.snap index 504994454..4cbb59935 100644 --- a/crates/oxc_linter/src/snapshots/no_dupe_keys.snap +++ b/crates/oxc_linter/src/snapshots/no_dupe_keys.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_dupe_keys --- - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { a: b, ['a']: b }; @@ -119,3 +118,4 @@ expression: no_dupe_keys ╰──── help: Consider removing the duplicated key + diff --git a/crates/oxc_linter/src/snapshots/no_duplicate_case.snap b/crates/oxc_linter/src/snapshots/no_duplicate_case.snap index 3892ab0e6..a1a149036 100644 --- a/crates/oxc_linter/src/snapshots/no_duplicate_case.snap +++ b/crates/oxc_linter/src/snapshots/no_duplicate_case.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: no_duplicate_case --- - ⚠ eslint(no-duplicate-case): Disallow duplicate case labels ╭─[no_duplicate_case.tsx:1:1] 1 │ var a = 1; switch (a) {case 1: break; case 1: break; case 2: break; default: break;} @@ -148,3 +146,4 @@ expression: no_duplicate_case ╰──── help: Remove the duplicated case + diff --git a/crates/oxc_linter/src/snapshots/no_empty.snap b/crates/oxc_linter/src/snapshots/no_empty.snap index 8284d27d8..c9b077b6a 100644 --- a/crates/oxc_linter/src/snapshots/no_empty.snap +++ b/crates/oxc_linter/src/snapshots/no_empty.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_empty --- - ⚠ eslint(no-empty): Disallow empty block statements ╭─[no_empty.tsx:1:1] 1 │ try {} catch (ex) {throw ex} @@ -115,3 +114,4 @@ expression: no_empty ╰──── help: Add comment inside empty block statement + diff --git a/crates/oxc_linter/src/snapshots/no_empty_pattern.snap b/crates/oxc_linter/src/snapshots/no_empty_pattern.snap index 1cfea865d..407c8707e 100644 --- a/crates/oxc_linter/src/snapshots/no_empty_pattern.snap +++ b/crates/oxc_linter/src/snapshots/no_empty_pattern.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_empty_pattern --- - ⚠ eslint(no-empty-pattern): Disallow empty destructuring patterns ╭─[no_empty_pattern.tsx:1:1] 1 │ var {} = foo @@ -66,3 +65,4 @@ expression: no_empty_pattern · ╰── Empty array binding pattern ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_function_assign.snap b/crates/oxc_linter/src/snapshots/no_function_assign.snap index 8c9cee4f2..9e9780222 100644 --- a/crates/oxc_linter/src/snapshots/no_function_assign.snap +++ b/crates/oxc_linter/src/snapshots/no_function_assign.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_function_assign --- - ⚠ eslint(no-function-assign): 'foo' is a function. ╭─[no_function_assign.tsx:1:1] 1 │ function foo() {}; foo = bar; @@ -59,3 +58,4 @@ expression: no_function_assign · ╰── foo is re-assigned here ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_mixed_operators.snap b/crates/oxc_linter/src/snapshots/no_mixed_operators.snap index 1813ffbde..d1c19773b 100644 --- a/crates/oxc_linter/src/snapshots/no_mixed_operators.snap +++ b/crates/oxc_linter/src/snapshots/no_mixed_operators.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_mixed_operators --- - ⚠ eslint(no-mixed-operators): Unexpected mix of && with || ╭─[no_mixed_operators.tsx:1:1] 1 │ a && b || c @@ -115,3 +114,4 @@ expression: no_mixed_operators ╰──── help: Use parentheses to clarify the intended order of operations. + diff --git a/crates/oxc_linter/src/snapshots/no_new_symbol.snap b/crates/oxc_linter/src/snapshots/no_new_symbol.snap index 4552231be..a2bab3b43 100644 --- a/crates/oxc_linter/src/snapshots/no_new_symbol.snap +++ b/crates/oxc_linter/src/snapshots/no_new_symbol.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_new_symbol --- - ⚠ eslint(no-new-symbol): Disallow new operators with the Symbol object ╭─[no_new_symbol.tsx:1:1] 1 │ var foo = new Symbol('foo'); @@ -17,3 +16,4 @@ expression: no_new_symbol ╰──── help: Symbol is not intended to be used with the new operator, but to be called as a function. Consider removing the new operator. + diff --git a/crates/oxc_linter/src/snapshots/no_self_compare.snap b/crates/oxc_linter/src/snapshots/no_self_compare.snap index 7b4e0c2a2..c1cfd36ca 100644 --- a/crates/oxc_linter/src/snapshots/no_self_compare.snap +++ b/crates/oxc_linter/src/snapshots/no_self_compare.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: no_self_compare --- - ⚠ eslint(no-self-compare): Disallow comparisons where both sides are exactly the same ╭─[no_self_compare.tsx:1:1] 1 │ if (x === x) { } @@ -109,3 +107,4 @@ expression: no_self_compare ╰──── help: If you are testing for NaN, you can use Number.isNaN function. + diff --git a/crates/oxc_linter/src/snapshots/no_shadow_restricted_names.snap b/crates/oxc_linter/src/snapshots/no_shadow_restricted_names.snap index aaafbf2a9..d66a6fda3 100644 --- a/crates/oxc_linter/src/snapshots/no_shadow_restricted_names.snap +++ b/crates/oxc_linter/src/snapshots/no_shadow_restricted_names.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_shadow_restricted_names --- - ⚠ eslint(no-shadow-restricted-names): Shadowing of global property 'NaN' ╭─[no_shadow_restricted_names.tsx:1:1] 1 │ function NaN(NaN) { var NaN; !function NaN(NaN) { try {} catch(NaN) {} }; } @@ -192,3 +191,4 @@ expression: no_shadow_restricted_names · ╰── Shadowing of global property 'undefined' ╰──── + diff --git a/crates/oxc_linter/src/snapshots/no_unsafe_negation.snap b/crates/oxc_linter/src/snapshots/no_unsafe_negation.snap index 4d4359593..81a17e673 100644 --- a/crates/oxc_linter/src/snapshots/no_unsafe_negation.snap +++ b/crates/oxc_linter/src/snapshots/no_unsafe_negation.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_unsafe_negation --- - ⚠ Unexpected logical not in the left hand side of 'in' operator ╭─[no_unsafe_negation.tsx:1:1] 1 │ !a in b @@ -80,3 +79,4 @@ expression: no_unsafe_negation ╰──── help: use parenthesis to express the negation of the whole boolean expression, as '!' binds more closely than '<=' + diff --git a/crates/oxc_linter/src/snapshots/no_unused_labels.snap b/crates/oxc_linter/src/snapshots/no_unused_labels.snap index 9ea61edf3..72e70ca41 100644 --- a/crates/oxc_linter/src/snapshots/no_unused_labels.snap +++ b/crates/oxc_linter/src/snapshots/no_unused_labels.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: no_unused_labels --- - ⚠ eslint(no-unused-labels): Disallow unused labels ╭─[no_unused_labels.tsx:1:1] 1 │ A: var foo = 0; @@ -66,3 +65,4 @@ expression: no_unused_labels ╰──── help: 'A:' is defined but never used. + diff --git a/crates/oxc_linter/src/snapshots/uninvoked_array_callback.snap b/crates/oxc_linter/src/snapshots/uninvoked_array_callback.snap index 67d0bed5a..e01244965 100644 --- a/crates/oxc_linter/src/snapshots/uninvoked_array_callback.snap +++ b/crates/oxc_linter/src/snapshots/uninvoked_array_callback.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: uninvoked_array_callback --- - ⚠ Uninvoked array callback ╭─[uninvoked_array_callback.tsx:1:1] 1 │ const list = new Array(5).map(_ => {}) @@ -30,3 +29,4 @@ expression: uninvoked_array_callback ╰──── help: consider filling the array with `undefined` values using `Array.prototype.fill()` + diff --git a/crates/oxc_linter/src/snapshots/use_isnan.snap b/crates/oxc_linter/src/snapshots/use_isnan.snap index 82e36a0b0..aa4c04b13 100644 --- a/crates/oxc_linter/src/snapshots/use_isnan.snap +++ b/crates/oxc_linter/src/snapshots/use_isnan.snap @@ -1,9 +1,7 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 53 expression: use_isnan --- - ⚠ eslint(use-isnan): Requires calls to isNaN() when checking for NaN ╭─[use_isnan.tsx:1:1] 1 │ 123 == NaN; @@ -606,3 +604,4 @@ expression: use_isnan ╰──── help: Array prototype method 'indexOf' cannot find NaN. + diff --git a/crates/oxc_linter/src/snapshots/valid_typeof.snap b/crates/oxc_linter/src/snapshots/valid_typeof.snap index 2153ed3ee..e81888fdf 100644 --- a/crates/oxc_linter/src/snapshots/valid_typeof.snap +++ b/crates/oxc_linter/src/snapshots/valid_typeof.snap @@ -2,7 +2,6 @@ source: crates/oxc_linter/src/tester.rs expression: valid_typeof --- - ⚠ eslint(valid-typeof): Invalid typeof comparison value. ╭─[valid_typeof.tsx:1:1] 1 │ typeof foo === 'strnig' @@ -133,3 +132,4 @@ expression: valid_typeof · ─────────── ╰──── + diff --git a/crates/oxc_linter/src/tester.rs b/crates/oxc_linter/src/tester.rs index 60551bdff..9f24ca51c 100644 --- a/crates/oxc_linter/src/tester.rs +++ b/crates/oxc_linter/src/tester.rs @@ -97,6 +97,7 @@ impl Tester { source_text.to_string(), )); handler.render_report(&mut self.snapshot, diagnostic.as_ref()).unwrap(); + self.snapshot.push('\n'); } false }