dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer): make branch more predictable in arrow function transform (#5833)

Browse source 
Micro-optimization. Rather than `inside_arrow_function_stack` sometimes being run down to empty, initialize it with a single entry which is never popped off. This means that `self.inside_arrow_function_stack.last()` *always* returns `Some` - so the branch is completely predictable.
This commit is contained in:
overlookmotel 2024-09-18 02:23:35 +00:00
parent 03a9e1ad5d
commit 56703a3a59
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_transformer/src/es2015/arrow_functions.rs
View file

@ -91,9 +91,9 @@ impl<'a> ArrowFunctions<'a> {
Self { Self {
ctx, ctx,
_options: options, _options: options,
// Initial entry for `Program` scope // Initial entries for `Program` scope
this_var_stack: vec![None], this_var_stack: vec![None],
inside_arrow_function_stack: vec![], inside_arrow_function_stack: vec![false],
} }
} }
} }
@ -101,7 +101,7 @@ impl<'a> ArrowFunctions<'a> {
impl<'a> Traverse<'a> for ArrowFunctions<'a> { impl<'a> Traverse<'a> for ArrowFunctions<'a> {
/// Insert `var _this = this;` for the global scope. /// Insert `var _this = this;` for the global scope.
fn exit_program(&mut self, program: &mut Program<'a>, _ctx: &mut TraverseCtx<'a>) { fn exit_program(&mut self, program: &mut Program<'a>, _ctx: &mut TraverseCtx<'a>) {
debug_assert!(self.inside_arrow_function_stack.is_empty()); debug_assert!(self.inside_arrow_function_stack.len() == 1);
assert!(self.this_var_stack.len() == 1); assert!(self.this_var_stack.len() == 1);
let this_var = self.this_var_stack.pop().unwrap(); let this_var = self.this_var_stack.pop().unwrap();
@ -238,7 +238,7 @@ impl<'a> Traverse<'a> for ArrowFunctions<'a> {
impl<'a> ArrowFunctions<'a> { impl<'a> ArrowFunctions<'a> {
fn is_inside_arrow_function(&self) -> bool { fn is_inside_arrow_function(&self) -> bool {
self.inside_arrow_function_stack.last().copied().unwrap_or(false) *self.inside_arrow_function_stack.last().unwrap()
} }
fn get_this_name(&mut self, ctx: &mut TraverseCtx<'a>) -> BoundIdentifier<'a> { fn get_this_name(&mut self, ctx: &mut TraverseCtx<'a>) -> BoundIdentifier<'a> {