dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/class-properties): rename debug_assert_expr_is_not_parenthesis_or_typescript_syntax (#7803)

Browse source 
Rename function to make it completely clear what it does.
This commit is contained in:
overlookmotel 2024-12-11 14:54:49 +00:00
parent 3cdc47cb0d
commit 54ef2b9e18
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/oxc_transformer/src/es2022/class_properties/private.rs
View file

@ -16,8 +16,8 @@ use crate::{common::helper_loader::Helper, TransformCtx};
use super::{
private_props::ResolvedPrivateProp,
utils::{
assert_expr_neither_parenthesis_nor_typescript_syntax, create_assignment,
create_underscore_ident_name,
create_assignment, create_underscore_ident_name,
debug_assert_expr_is_not_parenthesis_or_typescript_syntax,
},
ClassProperties,
};
@ -1019,7 +1019,10 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
self.transform_call_expression_of_chain_expression(call, ctx)
}
_ => {
assert_expr_neither_parenthesis_nor_typescript_syntax(expr, &self.ctx.source_path);
debug_assert_expr_is_not_parenthesis_or_typescript_syntax(
expr,
&self.ctx.source_path,
);
None
}
}
@ -1611,7 +1614,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
object: Expression<'a>,
ctx: &mut TraverseCtx<'a>,
) -> (Expression<'a>, Expression<'a>) {
assert_expr_neither_parenthesis_nor_typescript_syntax(&object, &self.ctx.source_path);
debug_assert_expr_is_not_parenthesis_or_typescript_syntax(&object, &self.ctx.source_path);
self.ctx.duplicate_expression(object, false, ctx)
}
@ -1630,7 +1633,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
object: Expression<'a>,
ctx: &mut TraverseCtx<'a>,
) -> (Expression<'a>, Expression<'a>, Expression<'a>) {
assert_expr_neither_parenthesis_nor_typescript_syntax(&object, &self.ctx.source_path);
debug_assert_expr_is_not_parenthesis_or_typescript_syntax(&object, &self.ctx.source_path);
self.ctx.duplicate_expression_twice(object, false, ctx)
}

5
crates/oxc_transformer/src/es2022/class_properties/utils.rs
View file

@ -56,10 +56,13 @@ pub(super) fn create_underscore_ident_name<'a>(ctx: &mut TraverseCtx<'a>) -> Ide
ctx.ast.identifier_name(SPAN, Atom::from("_"))
}
/// Debug assert that an `Expression` is not `ParenthesizedExpression` or TS syntax
/// (e.g. `TSAsExpression`).
//
// `#[inline(always)]` because this is a no-op in release mode
#[expect(clippy::inline_always)]
#[inline(always)]
pub(super) fn assert_expr_neither_parenthesis_nor_typescript_syntax(
pub(super) fn debug_assert_expr_is_not_parenthesis_or_typescript_syntax(
expr: &Expression,
path: &PathBuf,
) {