dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(minifier): x['-2147483648'] -> x[-2147483648] (#8528)

Browse source
This commit is contained in:
Boshen 2025-01-16 13:43:23 +08:00 committed by GitHub
parent 405b73d8e7
commit 53adde5003
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_minifier/src/ast_passes/convert_to_dotted_properties.rs
View file

@ -309,7 +309,7 @@ mod test {
test_same("x['-0x1']");
test("x['2147483647']", "x[2147483647]");
test_same("x['2147483648']");
test_same("x['-2147483648']");
test("x['-2147483648']", "x[-2147483648]");
test_same("x['-2147483649']");
}
}

17
crates/oxc_minifier/src/ctx.rs
View file

@ -94,21 +94,24 @@ impl<'a> Ctx<'a, '_> {
let bytes = s.as_bytes();
if bytes[0] == b'-' && s.len() > 1 {
is_negative = true;
int_value = -int_value;
start += 1;
}
if bytes[start] == b'0' && s.len() > 1 {
return None;
}
for b in &bytes[start..] {
if b.is_ascii_digit() {
int_value =
int_value.checked_mul(10).and_then(|v| v.checked_add(i32::from(b & 15)))?;
} else {
if !b.is_ascii_digit() {
return None;
}
}
if is_negative {
int_value = -int_value;
int_value = int_value.checked_mul(10).and_then(|v| {
let n = i32::from(b & 15);
if is_negative {
v.checked_sub(n)
} else {
v.checked_add(n)
}
})?;
}
Some(f64::from(int_value))
}

12
tasks/minsize/minsize.snap
View file

@ -7,7 +7,7 @@ Original | minified | minified | gzip | gzip | Fixture
287.63 kB | 90.08 kB | 90.07 kB | 32.03 kB | 31.95 kB | jquery.js
342.15 kB | 118.11 kB | 118.14 kB | 44.44 kB | 44.37 kB | vue.js
342.15 kB | 118.14 kB | 118.14 kB | 44.45 kB | 44.37 kB | vue.js
544.10 kB | 71.76 kB | 72.48 kB | 26.15 kB | 26.20 kB | lodash.js
@ -15,13 +15,13 @@ Original | minified | minified | gzip | gzip | Fixture
1.01 MB | 460.17 kB | 458.89 kB | 126.76 kB | 126.71 kB | bundle.min.js
1.25 MB | 652.80 kB | 646.76 kB | 163.53 kB | 163.73 kB | three.js
1.25 MB | 652.88 kB | 646.76 kB | 163.54 kB | 163.73 kB | three.js
2.14 MB | 725.52 kB | 724.14 kB | 180.05 kB | 181.07 kB | victory.js
2.14 MB | 725.56 kB | 724.14 kB | 180.06 kB | 181.07 kB | victory.js
3.20 MB | 1.01 MB | 1.01 MB | 331.77 kB | 331.56 kB | echarts.js
3.20 MB | 1.01 MB | 1.01 MB | 332.02 kB | 331.56 kB | echarts.js
6.69 MB | 2.32 MB | 2.31 MB | 492.62 kB | 488.28 kB | antd.js
6.69 MB | 2.32 MB | 2.31 MB | 492.64 kB | 488.28 kB | antd.js
10.95 MB | 3.49 MB | 3.49 MB | 907.11 kB | 915.50 kB | typescript.js
10.95 MB | 3.49 MB | 3.49 MB | 907.34 kB | 915.50 kB | typescript.js