From 5261547c25bdc0286f4b3ba698faf888b1c73179 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Wed, 27 Nov 2024 11:24:10 +0000
Subject: [PATCH] refactor(transformer/class-properties): remove a branch from
 `transform_call_expression_impl` (#7507)

Small optimization. `transform_call_expression_impl` does not require the `Expression::CallExpression`, only the `CallExpression` itself. So pass that into the function, instead of having to unwrap it (which is an unnecessary branch).
---
 .../src/es2022/class_properties/private.rs                | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/oxc_transformer/src/es2022/class_properties/private.rs b/crates/oxc_transformer/src/es2022/class_properties/private.rs
index 2bca885c3..02b16bff3 100644
--- a/crates/oxc_transformer/src/es2022/class_properties/private.rs
+++ b/crates/oxc_transformer/src/es2022/class_properties/private.rs
@@ -128,21 +128,21 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
     ) {
         let Expression::CallExpression(call_expr) = expr else { unreachable!() };
         if matches!(&call_expr.callee, Expression::PrivateFieldExpression(_)) {
-            self.transform_call_expression_impl(expr, ctx);
+            self.transform_call_expression_impl(call_expr, ctx);
         };
     }
 
     fn transform_call_expression_impl(
         &mut self,
-        expr: &mut Expression<'a>,
+        call_expr: &mut CallExpression<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) {
-        // Unfortunately no way to make compiler see that these branches are provably unreachable.
+        // Unfortunately no way to make compiler see that this branch is provably unreachable.
         // This function is much too large to inline.
-        let Expression::CallExpression(call_expr) = expr else { unreachable!() };
         let Expression::PrivateFieldExpression(field_expr) = &mut call_expr.callee else {
             unreachable!()
         };
+
         let prop_details = self.lookup_private_property(&field_expr.field);
         // TODO: Should never be `None` - only because implementation is incomplete.
         let Some((prop, class_name_binding, is_declaration)) = prop_details else { return };