From 5212f7b51e1939255dc7112a72ef67c1f1e15f7a Mon Sep 17 00:00:00 2001 From: Boshen Date: Sat, 24 Feb 2024 16:51:00 +0800 Subject: [PATCH] fix(parser): fix missing end span from `TSTypeAliasDeclaration` (#2485) closes #2483 --- crates/oxc_parser/src/ts/statement.rs | 1 + tasks/prettier_conformance/prettier.ts.snap.md | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/crates/oxc_parser/src/ts/statement.rs b/crates/oxc_parser/src/ts/statement.rs index 84596b0b2..bb1d4f757 100644 --- a/crates/oxc_parser/src/ts/statement.rs +++ b/crates/oxc_parser/src/ts/statement.rs @@ -111,6 +111,7 @@ impl<'a> ParserImpl<'a> { let annotation = self.parse_ts_type()?; self.asi()?; + let span = self.end_span(span); Ok(self.ast.ts_type_alias_declaration(span, id, annotation, params, modifiers)) } diff --git a/tasks/prettier_conformance/prettier.ts.snap.md b/tasks/prettier_conformance/prettier.ts.snap.md index f41f94c80..3bbd5a746 100644 --- a/tasks/prettier_conformance/prettier.ts.snap.md +++ b/tasks/prettier_conformance/prettier.ts.snap.md @@ -1,4 +1,4 @@ -ts compatibility: 20/528 (3.79%) +ts compatibility: 22/528 (4.17%) # Failed @@ -598,9 +598,6 @@ ts compatibility: 20/528 (3.79%) * last-argument-expansion/edge_case.ts * last-argument-expansion/forward-ref.tsx -### literal -* literal/multiline.ts - ### mapped-type * mapped-type/intersection.ts * mapped-type/issue-11098.ts @@ -758,7 +755,6 @@ ts compatibility: 20/528 (3.79%) * tsx/url.tsx ### tuple -* tuple/dangling-comments.ts * tuple/trailing-comma-for-empty-tuples.ts * tuple/trailing-comma-trailing-rest.ts * tuple/trailing-comma.ts