dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer): rename wrap_in_arrow_function_iife (#8546)

Browse source 
Pure refactor. Rename this function to be more descriptive.
This commit is contained in:
overlookmotel 2025-01-16 14:55:50 +00:00
parent 61077cae9f
commit 5206c6ae06
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_transformer/src/common/arrow_function_converter.rs
View file

@ -102,7 +102,7 @@ use oxc_syntax::{
}; };
use oxc_traverse::{Ancestor, BoundIdentifier, Traverse, TraverseCtx}; use oxc_traverse::{Ancestor, BoundIdentifier, Traverse, TraverseCtx};
use crate::{utils::ast_builder::wrap_arrow_function_iife, EnvOptions}; use crate::{utils::ast_builder::wrap_expression_in_arrow_function_iife, EnvOptions};
type FxIndexMap<K, V> = IndexMap<K, V, FxBuildHasher>; type FxIndexMap<K, V> = IndexMap<K, V, FxBuildHasher>;
@ -419,7 +419,7 @@ impl<'a> Traverse<'a> for ArrowFunctionConverter<'a> {
// prop = (() => { return async () => {} })(); // prop = (() => { return async () => {} })();
// } // }
// ``` // ```
Some(wrap_arrow_function_iife(ctx.ast.move_expression(expr), ctx)) Some(wrap_expression_in_arrow_function_iife(ctx.ast.move_expression(expr), ctx))
} else { } else {
return; return;
} }

6
crates/oxc_transformer/src/es2020/optional_chaining.rs
View file

@ -54,7 +54,7 @@ use oxc_ast::{ast::*, NONE};
use oxc_span::SPAN; use oxc_span::SPAN;
use oxc_traverse::{Ancestor, BoundIdentifier, MaybeBoundIdentifier, Traverse, TraverseCtx}; use oxc_traverse::{Ancestor, BoundIdentifier, MaybeBoundIdentifier, Traverse, TraverseCtx};
use crate::{utils::ast_builder::wrap_arrow_function_iife, TransformCtx}; use crate::{utils::ast_builder::wrap_expression_in_arrow_function_iife, TransformCtx};
#[derive(Debug)] #[derive(Debug)]
enum CallContext<'a> { enum CallContext<'a> {
@ -283,7 +283,7 @@ impl<'a> OptionalChaining<'a, '_> {
// To insert the temp binding in the correct scope, we wrap the expression with // To insert the temp binding in the correct scope, we wrap the expression with
// an arrow function. During the chain expression transformation, the temp binding // an arrow function. During the chain expression transformation, the temp binding
// will be inserted into the arrow function's body. // will be inserted into the arrow function's body.
wrap_arrow_function_iife(ctx.ast.move_expression(expr), ctx) wrap_expression_in_arrow_function_iife(ctx.ast.move_expression(expr), ctx)
} else { } else {
self.transform_chain_expression_impl(false, expr, ctx) self.transform_chain_expression_impl(false, expr, ctx)
} }
@ -297,7 +297,7 @@ impl<'a> OptionalChaining<'a, '_> {
) { ) {
*expr = if self.is_inside_function_parameter { *expr = if self.is_inside_function_parameter {
// Same as the above `transform_chain_expression` explanation // Same as the above `transform_chain_expression` explanation
wrap_arrow_function_iife(ctx.ast.move_expression(expr), ctx) wrap_expression_in_arrow_function_iife(ctx.ast.move_expression(expr), ctx)
} else { } else {
// Unfortunately no way to get compiler to see that this branch is provably unreachable. // Unfortunately no way to get compiler to see that this branch is provably unreachable.
// We don't want to inline this function, to keep `enter_expression` as small as possible. // We don't want to inline this function, to keep `enter_expression` as small as possible.

2
crates/oxc_transformer/src/utils/ast_builder.rs
View file

@ -41,7 +41,7 @@ pub(crate) fn create_call_call<'a>(
/// with a body block. /// with a body block.
/// ///
/// `expr` -> `(() => { return expr; })()` /// `expr` -> `(() => { return expr; })()`
pub(crate) fn wrap_arrow_function_iife<'a>( pub(crate) fn wrap_expression_in_arrow_function_iife<'a>(
expr: Expression<'a>, expr: Expression<'a>,
ctx: &mut TraverseCtx<'a>, ctx: &mut TraverseCtx<'a>,
) -> Expression<'a> { ) -> Expression<'a> {