dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter): Added fixer for duplicate prefix in valid title jest rule (#6699)

Browse source
This commit is contained in:
Tapan Prakash 2024-10-20 20:16:49 +05:30 committed by GitHub
parent 01a35bb446
commit 5095f027e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 54 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
crates/oxc_linter/src/rules/jest/valid_title.rs
View file

@ -312,9 +312,12 @@ fn validate_title(
return; return;
}; };
// TODO: support fixer
if first_word == un_prefixed_name { if first_word == un_prefixed_name {
Message::DuplicatePrefix.diagnostic(ctx, span); let (error, help) = Message::DuplicatePrefix.detail();
ctx.diagnostic_with_fix(valid_title_diagnostic(error, help, span), |fixer| {
let replaced_title = title[first_word.len()..].trim().to_string();
fixer.replace(span.shrink_left(1).shrink_right(1), replaced_title)
});
return; return;
} }
@ -967,6 +970,55 @@ fn test() {
}) })
", ",
), ),
("describe('describe foo', function () {})", "describe('foo', function () {})"),
("fdescribe('describe foo', function () {})", "fdescribe('foo', function () {})"),
("xdescribe('describe foo', function () {})", "xdescribe('foo', function () {})"),
("describe('describe foo', function () {})", "describe('foo', function () {})"),
("fdescribe(`describe foo`, function () {})", "fdescribe(`foo`, function () {})"),
("test('test foo', function () {})", "test('foo', function () {})"),
("xtest('test foo', function () {})", "xtest('foo', function () {})"),
("test(`test foo`, function () {})", "test(`foo`, function () {})"),
("test(`test foo test`, function () {})", "test(`foo test`, function () {})"),
("it('it foo', function () {})", "it('foo', function () {})"),
("fit('it foo', function () {})", "fit('foo', function () {})"),
("xit('it foo', function () {})", "xit('foo', function () {})"),
("it('it foos it correctly', function () {})", "it('foos it correctly', function () {})"),
(
"
describe('describe foo', () => {
it('bar', () => {})
})
",
"
describe('foo', () => {
it('bar', () => {})
})
",
),
(
"
describe('describe foo', () => {
it('describes things correctly', () => {})
})
",
"
describe('foo', () => {
it('describes things correctly', () => {})
})
",
),
(
"
describe('foo', () => {
it('it bar', () => {})
})
",
"
describe('foo', () => {
it('bar', () => {})
})
",
),
]; ];
Tester::new(ValidTitle::NAME, pass, fail) Tester::new(ValidTitle::NAME, pass, fail)