fix(prettier) fix use chain formatting (#1605)

This commit is contained in:
Cameron 2023-12-02 07:44:25 +00:00 committed by GitHub
parent 811b219b27
commit 502d61dc9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 12 deletions

View file

@ -146,16 +146,17 @@ fn choose_layout<'a>(
let is_tail = !is_assignment(right_expr);
let should_use_chain_formatting = matches!(p.parent_kind(), AstKind::AssignmentExpression(_))
&& matches!(
p.parent_parent_kind(),
Some(AstKind::AssignmentExpression(_) | AstKind::VariableDeclarator(_))
)
&& (!is_tail
|| !matches!(
p.nth_parent_kind(3),
Some(AstKind::ExpressionStatement(_) | AstKind::VariableDeclaration(_))
));
let should_use_chain_formatting =
matches!(assignment_like_node, AssignmentLikeNode::AssignmentExpression(_))
&& matches!(
p.parent_kind(),
AstKind::AssignmentExpression(_) | AstKind::VariableDeclarator(_)
)
&& (!is_tail
|| !matches!(
p.parent_parent_kind(),
Some(AstKind::ExpressionStatement(_) | AstKind::VariableDeclaration(_))
));
if should_use_chain_formatting {
if !is_tail {

View file

@ -108,6 +108,7 @@ impl<'a> Prettier<'a> {
(len >= 3).then(|| self.nodes[len - 3])
}
#[allow(unused)]
fn nth_parent_kind(&self, n: usize) -> Option<AstKind<'a>> {
let len = self.nodes.len();
(len > n).then(|| self.nodes[len - n - 1])

View file

@ -1,4 +1,4 @@
Compatibility: 216/561 (38.50%)
Compatibility: 217/561 (38.68%)
# Failed
@ -48,7 +48,6 @@ Compatibility: 216/561 (38.50%)
* assignment/issue-15534.js
* assignment/issue-2482-2.js
* assignment/issue-2540.js
* assignment/issue-3819.js
* assignment/issue-6922.js
* assignment/issue-7572.js
* assignment/lone-arg.js