dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter/unicorn): add fixer for prefer-type-error (#5311)

Browse source
This commit is contained in:
camc314 2024-08-31 05:17:47 +00:00
parent 295ad89b7e
commit 4c0861f694
1 changed files with 57 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
crates/oxc_linter/src/rules/unicorn/prefer_type_error.rs
View file

@ -43,7 +43,7 @@ declare_oxc_lint!(
/// ``` /// ```
PreferTypeError, PreferTypeError,
pedantic, pedantic,
pending fix
); );
impl Rule for PreferTypeError { impl Rule for PreferTypeError {
@ -82,7 +82,10 @@ impl Rule for PreferTypeError {
}; };
if is_type_checking_expr(&if_stmt.test) { if is_type_checking_expr(&if_stmt.test) {
ctx.diagnostic(prefer_type_error_diagnostic(new_expr.callee.span())); ctx.diagnostic_with_fix(
prefer_type_error_diagnostic(new_expr.callee.span()),
|fixer| fixer.replace(new_expr.callee.span(), "TypeError"),
);
} }
} }
} }
@ -468,5 +471,56 @@ fn test() {
", ",
]; ];
Tester::new(PreferTypeError::NAME, pass, fail).test_and_snapshot(); let fix = vec![
(
r"if (!isFinite(foo)) { throw new Error(); }",
r"if (!isFinite(foo)) { throw new TypeError(); }",
),
(
r"if (isNaN(foo) === false) { throw new Error(); }",
r"if (isNaN(foo) === false) { throw new TypeError(); }",
),
(
r"if (Array.isArray(foo)) { throw new Error('foo is an Array'); }",
r"if (Array.isArray(foo)) { throw new TypeError('foo is an Array'); }",
),
(
r"if (foo instanceof bar) { throw new Error(foobar); }",
r"if (foo instanceof bar) { throw new TypeError(foobar); }",
),
(
r"if (_.isElement(foo)) { throw new Error(); }",
r"if (_.isElement(foo)) { throw new TypeError(); }",
),
(
r"if (_.isElement(foo)) { throw new Error; }",
r"if (_.isElement(foo)) { throw new TypeError; }",
),
(
r"if (wrapper._.isElement(foo)) { throw new Error; }",
r"if (wrapper._.isElement(foo)) { throw new TypeError; }",
),
(
r"if (typeof foo == 'Foo' || 'Foo' === typeof foo) { throw new Error(); }",
r"if (typeof foo == 'Foo' || 'Foo' === typeof foo) { throw new TypeError(); }",
),
(
r"if (Number.isFinite(foo) && Number.isSafeInteger(foo) && Number.isInteger(foo)) { throw new Error(); }",
r"if (Number.isFinite(foo) && Number.isSafeInteger(foo) && Number.isInteger(foo)) { throw new TypeError(); }",
),
(
r"if (wrapper.n.isFinite(foo) && wrapper.n.isSafeInteger(foo) && wrapper.n.isInteger(foo)) { throw new Error(); }",
r"if (wrapper.n.isFinite(foo) && wrapper.n.isSafeInteger(foo) && wrapper.n.isInteger(foo)) { throw new TypeError(); }",
),
(
r"if (wrapper.f.g.n.isFinite(foo) && wrapper.g.n.isSafeInteger(foo) && wrapper.n.isInteger(foo)) { throw new Error(); }",
r"if (wrapper.f.g.n.isFinite(foo) && wrapper.g.n.isSafeInteger(foo) && wrapper.n.isInteger(foo)) { throw new TypeError(); }",
),
(
r"if (_.isElement(foo)) { throw (new Error()); }",
r"if (_.isElement(foo)) { throw (new TypeError()); }",
),
];
Tester::new(PreferTypeError::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
} }