From 48242367bb643ae7477c3fff753071fbe4850a59 Mon Sep 17 00:00:00 2001 From: Dunqing Date: Sat, 11 Nov 2023 10:45:42 +0800 Subject: [PATCH] fix(transformer/react-jsx): missing import jsxs in nested fragment (#1218) --- crates/oxc_transformer/src/react_jsx/mod.rs | 7 ++++++- tasks/transform_conformance/babel.snap.md | 1 - 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/crates/oxc_transformer/src/react_jsx/mod.rs b/crates/oxc_transformer/src/react_jsx/mod.rs index 2620c45d4..52c89af79 100644 --- a/crates/oxc_transformer/src/react_jsx/mod.rs +++ b/crates/oxc_transformer/src/react_jsx/mod.rs @@ -158,7 +158,12 @@ impl<'a> ReactJsx<'a> { } JSXElementOrFragment::Element(_) if need_jsxs => self.add_import_jsxs(), JSXElementOrFragment::Element(_) => self.add_import_jsx(), - JSXElementOrFragment::Fragment(_) => self.add_import_fragment(), + JSXElementOrFragment::Fragment(_) => { + self.add_import_fragment(); + if need_jsxs { + self.add_import_jsxs(); + } + } } } diff --git a/tasks/transform_conformance/babel.snap.md b/tasks/transform_conformance/babel.snap.md index e19c4b943..0f31c61e9 100644 --- a/tasks/transform_conformance/babel.snap.md +++ b/tasks/transform_conformance/babel.snap.md @@ -875,7 +875,6 @@ Passed: 266/1113 * react-automatic/arrow-functions/input.js * react-automatic/optimisation.react.constant-elements/input.js * react-automatic/should-add-quotes-es3/input.js -* react-automatic/should-allow-nested-fragments/input.js * react-automatic/should-disallow-spread-children/input.js * react-automatic/should-disallow-valueless-key/input.js * react-automatic/should-disallow-xml-namespacing/input.js