dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/class-properties): shorten code (#7804)

Browse source 
Follow-on after #7798. Pure refactor, just shorten code.

I *think* `expect` has same behavior as `unreachable!` in terms of making the compiler backtrack to try to prove the check can be elided. But in this case, I doubt it can prove it either way.
This commit is contained in:
overlookmotel 2024-12-11 14:54:49 +00:00
parent 54ef2b9e18
commit 47a91d2bdc
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/oxc_transformer/src/es2022/class_properties/private.rs
View file

@ -961,11 +961,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
let mut chain_expr = Self::convert_chain_expression_to_expression(expr, ctx);
let result = self
.transform_private_field_expression_of_chain_expression(&mut chain_expr, ctx)
.unwrap_or_else(|| {
unreachable!(
"The ChainExpression must contains at least one optional expression, so it never be `None` here."
)
});
.expect("The ChainExpression must contain at least one optional expression, so it can never be `None` here.");
Some((result, chain_expr))
} else if let Some(result) = self.transform_chain_expression_element(element, ctx) {
let chain_expr = Self::convert_chain_expression_to_expression(expr, ctx);