dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast)!: remove impl GetAddress for Function (#7343)

Browse source 
`impl GetAddress for Function` was added as a hack, in the absence of another way to get the `Address` of a `&Function` (https://github.com/oxc-project/backlog/issues/140).

Remove it, and use `Address:from_ptr` instead in JSX Refresh transform, which is only place using it.
This commit is contained in:
overlookmotel 2024-11-19 01:05:30 +00:00
parent 4b8aecc8ed
commit 41a0e60c3e
2 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/oxc_ast/src/ast_impl/js.rs
View file

@ -1011,16 +1011,6 @@ impl<'a> Function<'a> {
} }
} }
// FIXME: This is a workaround for we can't get current address by `TraverseCtx`,
// we will remove this once we support `TraverseCtx::current_address`.
// See: <https://github.com/oxc-project/oxc/pull/6881#discussion_r1816560516>
impl GetAddress for Function<'_> {
#[inline]
fn address(&self) -> Address {
Address::from_ptr(self)
}
}
impl<'a> FormalParameters<'a> { impl<'a> FormalParameters<'a> {
/// Number of parameters bound in this parameter list. /// Number of parameters bound in this parameter list.
pub fn parameters_count(&self) -> usize { pub fn parameters_count(&self) -> usize {

7
crates/oxc_transformer/src/jsx/refresh.rs
View file

@ -2,7 +2,7 @@ use base64::prelude::{Engine, BASE64_STANDARD};
use rustc_hash::FxHashMap; use rustc_hash::FxHashMap;
use sha1::{Digest, Sha1}; use sha1::{Digest, Sha1};
use oxc_allocator::{CloneIn, GetAddress, Vec as ArenaVec}; use oxc_allocator::{Address, CloneIn, GetAddress, Vec as ArenaVec};
use oxc_ast::{ast::*, match_expression, AstBuilder, NONE}; use oxc_ast::{ast::*, match_expression, AstBuilder, NONE};
use oxc_semantic::{Reference, ReferenceFlags, ScopeFlags, ScopeId, SymbolFlags}; use oxc_semantic::{Reference, ReferenceFlags, ScopeFlags, ScopeId, SymbolFlags};
use oxc_span::{Atom, GetSpan, SPAN}; use oxc_span::{Atom, GetSpan, SPAN};
@ -289,8 +289,9 @@ impl<'a, 'ctx> Traverse<'a> for ReactRefresh<'a, 'ctx> {
// which is a `Statement::ExportDefaultDeclaration` // which is a `Statement::ExportDefaultDeclaration`
Ancestor::ExportDefaultDeclarationDeclaration(decl) => decl.address(), Ancestor::ExportDefaultDeclarationDeclaration(decl) => decl.address(),
// Otherwise just a `function Foo() {}` // Otherwise just a `function Foo() {}`
// which is a `Statement::FunctionDeclaration` // which is a `Statement::FunctionDeclaration`.
_ => func.address(), // `Function` is always stored in a `Box`, so has a stable memory address.
_ => Address::from_ptr(func),
}; };
self.ctx.statement_injector.insert_after(&address, statement); self.ctx.statement_injector.insert_after(&address, statement);
} }