From 407e406f86d7b337bb2461a5e28c9ec4e0fdbffd Mon Sep 17 00:00:00 2001
From: Boshen <boshenc@gmail.com>
Date: Mon, 30 Oct 2023 17:42:15 +0800
Subject: [PATCH] feat(linter): change some rules pedantic and improve help
 message (#1112)

---
 .../oxc_linter/src/rules/eslint/no_prototype_builtins.rs  | 2 +-
 .../oxc_linter/src/rules/unicorn/no_instanceof_array.rs   | 2 +-
 .../unicorn/require_number_to_fixed_digits_argument.rs    | 4 ++--
 .../require_number_to_fixed_digits_argument.snap          | 8 ++++----
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/crates/oxc_linter/src/rules/eslint/no_prototype_builtins.rs b/crates/oxc_linter/src/rules/eslint/no_prototype_builtins.rs
index b64223741..81e3ba666 100644
--- a/crates/oxc_linter/src/rules/eslint/no_prototype_builtins.rs
+++ b/crates/oxc_linter/src/rules/eslint/no_prototype_builtins.rs
@@ -44,7 +44,7 @@ declare_oxc_lint!(
     /// var barIsEnumerable = foo.propertyIsEnumerable("bar");
     /// ```
     NoPrototypeBuiltins,
-    correctness
+    pedantic
 );
 
 const DISALLOWED_PROPS: &[&str; 3] = &["hasOwnProperty", "isPrototypeOf", "propertyIsEnumerable"];
diff --git a/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs b/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs
index 37a719e20..b73548462 100644
--- a/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs
+++ b/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs
@@ -32,7 +32,7 @@ declare_oxc_lint!(
     /// [1,2,3] instanceof Array;
     /// ```
     NoInstanceofArray,
-    correctness
+    pedantic
 );
 
 impl Rule for NoInstanceofArray {
diff --git a/crates/oxc_linter/src/rules/unicorn/require_number_to_fixed_digits_argument.rs b/crates/oxc_linter/src/rules/unicorn/require_number_to_fixed_digits_argument.rs
index 490786921..df28609fd 100644
--- a/crates/oxc_linter/src/rules/unicorn/require_number_to_fixed_digits_argument.rs
+++ b/crates/oxc_linter/src/rules/unicorn/require_number_to_fixed_digits_argument.rs
@@ -10,7 +10,7 @@ use crate::{context::LintContext, fixer::Fix, rule::Rule, AstNode};
 
 #[derive(Debug, Error, Diagnostic)]
 #[error("eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument")]
-#[diagnostic(severity(warning), help("Pass an argument to .toFixed() method."))]
+#[diagnostic(severity(warning), help("It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0."))]
 struct RequireNumberToFixedDigitsArgumentDiagnostic(#[label] pub Span);
 
 #[derive(Debug, Default, Clone)]
@@ -34,7 +34,7 @@ declare_oxc_lint!(
     /// number.toFixed();
     /// ```
     RequireNumberToFixedDigitsArgument,
-    correctness
+    pedantic
 );
 
 impl Rule for RequireNumberToFixedDigitsArgument {
diff --git a/crates/oxc_linter/src/snapshots/require_number_to_fixed_digits_argument.snap b/crates/oxc_linter/src/snapshots/require_number_to_fixed_digits_argument.snap
index 8823c60cc..729bd59c7 100644
--- a/crates/oxc_linter/src/snapshots/require_number_to_fixed_digits_argument.snap
+++ b/crates/oxc_linter/src/snapshots/require_number_to_fixed_digits_argument.snap
@@ -7,27 +7,27 @@ expression: require_number_to_fixed_digits_argument
  1 │ const string = number.toFixed();
    ·                              ──
    ╰────
-  help: Pass an argument to .toFixed() method.
+  help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
 
   ⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
    ╭─[require_number_to_fixed_digits_argument.tsx:1:1]
  1 │ const string = number.toFixed( /* comment */ );
    ·                              ─────────────────
    ╰────
-  help: Pass an argument to .toFixed() method.
+  help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
 
   ⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
    ╭─[require_number_to_fixed_digits_argument.tsx:1:1]
  1 │ Number(1).toFixed()
    ·                  ──
    ╰────
-  help: Pass an argument to .toFixed() method.
+  help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
 
   ⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
    ╭─[require_number_to_fixed_digits_argument.tsx:1:1]
  1 │ const bigNumber = new BigNumber(1); const string = bigNumber.toFixed();
    ·                                                                     ──
    ╰────
-  help: Pass an argument to .toFixed() method.
+  help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.