dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter): change some rules pedantic and improve help message (#1112)

Browse source
This commit is contained in:
Boshen 2023-10-30 17:42:15 +08:00 committed by GitHub
parent 144c881be5
commit 407e406f86
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_linter/src/rules/eslint/no_prototype_builtins.rs
View file

@ -44,7 +44,7 @@ declare_oxc_lint!(
/// var barIsEnumerable = foo.propertyIsEnumerable("bar");
/// ```
NoPrototypeBuiltins,
correctness
pedantic
);
const DISALLOWED_PROPS: &[&str; 3] = &["hasOwnProperty", "isPrototypeOf", "propertyIsEnumerable"];

2
crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs
View file

@ -32,7 +32,7 @@ declare_oxc_lint!(
/// [1,2,3] instanceof Array;
/// ```
NoInstanceofArray,
correctness
pedantic
);
impl Rule for NoInstanceofArray {

4
crates/oxc_linter/src/rules/unicorn/require_number_to_fixed_digits_argument.rs
View file

@ -10,7 +10,7 @@ use crate::{context::LintContext, fixer::Fix, rule::Rule, AstNode};
#[derive(Debug, Error, Diagnostic)]
#[error("eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument")]
#[diagnostic(severity(warning), help("Pass an argument to .toFixed() method."))]
#[diagnostic(severity(warning), help("It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0."))]
struct RequireNumberToFixedDigitsArgumentDiagnostic(#[label] pub Span);
#[derive(Debug, Default, Clone)]
@ -34,7 +34,7 @@ declare_oxc_lint!(
/// number.toFixed();
/// ```
RequireNumberToFixedDigitsArgument,
correctness
pedantic
);
impl Rule for RequireNumberToFixedDigitsArgument {

8
crates/oxc_linter/src/snapshots/require_number_to_fixed_digits_argument.snap
View file

@ -7,27 +7,27 @@ expression: require_number_to_fixed_digits_argument
1 │ const string = number.toFixed();
· ──
╰────
help: Pass an argument to .toFixed() method.
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
╭─[require_number_to_fixed_digits_argument.tsx:1:1]
1 │ const string = number.toFixed( /* comment */ );
· ─────────────────
╰────
help: Pass an argument to .toFixed() method.
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
╭─[require_number_to_fixed_digits_argument.tsx:1:1]
1 │ Number(1).toFixed()
· ──
╰────
help: Pass an argument to .toFixed() method.
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
╭─[require_number_to_fixed_digits_argument.tsx:1:1]
1 │ const bigNumber = new BigNumber(1); const string = bigNumber.toFixed();
· ──
╰────
help: Pass an argument to .toFixed() method.
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.