dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(minifier): do not change delete undefined to delete void 0 (#8527)

Browse source 
`delete undefined` returns `false`
`delete void 0` returns `true`
This commit is contained in:
Boshen 2025-01-16 03:08:26 +00:00
parent 92e44cba6b
commit 405b73d8e7
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs
View file

@ -250,6 +250,12 @@ impl<'a, 'b> PeepholeSubstituteAlternateSyntax {
if !ctx.is_identifier_undefined(ident) {
return None;
}
// `delete undefined` returns `false`
// `delete void 0` returns `true`
if matches!(ctx.parent(), Ancestor::UnaryExpressionArgument(e) if e.operator().is_delete())
{
return None;
}
Some(ctx.ast.void_0(ident.span))
}
@ -1297,6 +1303,9 @@ mod test {
// destructuring throw error side effect
test_same("var {} = void 0");
test_same("var [] = void 0");
// `delete undefined` returns `false`
// `delete void 0` returns `true`
test_same("delete undefined");
}
#[test]