dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 20:32:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): improve error and help message on no-duplicate-enum-values

Browse source
This commit is contained in:
Boshen 2023-08-21 11:29:18 +08:00
parent a1c2fa65f7
commit 4032e4799c
No known key found for this signature in database
GPG key ID: 234DA6A7079C6801
2 changed files with 39 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
crates/oxc_linter/src/rules/typescript/no_duplicate_enum_values.rs
View file

@ -6,14 +6,17 @@ use oxc_diagnostics::{
};
use oxc_macros::declare_oxc_lint;
use oxc_span::{Atom, Span};
use rustc_hash::FxHashSet;
use rustc_hash::FxHashMap;
use crate::{context::LintContext, rule::Rule, AstNode};
#[derive(Debug, Error, Diagnostic)]
#[error("Disallow duplicate enum member values")]
#[diagnostic(severity(warning))]
struct NoDuplicateEnumValuesDiagnostic(#[label] pub Span);
#[error("typescript-eslint(no-duplicate-enum-values): Disallow duplicate enum member values")]
#[diagnostic(
severity(warning),
help("Duplicate values can lead to bugs that are hard to track down")
)]
struct NoDuplicateEnumValuesDiagnostic(#[label] Span, #[label] Span);
#[derive(Debug, Default, Clone)]
pub struct NoDuplicateEnumValues;
@ -37,24 +40,27 @@ declare_oxc_lint!(
);
impl Rule for NoDuplicateEnumValues {
#[allow(clippy::float_cmp)]
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let AstKind::TSEnumBody(enum_body) = node.kind() else { return };
let mut seen_number_values: Vec<f64> = Vec::new();
let mut seen_string_values: FxHashSet<&Atom> = FxHashSet::default();
let mut seen_number_values: Vec<(f64, Span)> = vec![];
let mut seen_string_values: FxHashMap<&Atom, Span> = FxHashMap::default();
for enum_member in &enum_body.members {
let Some(initializer) = &enum_member.initializer else { continue };
match initializer {
Expression::NumberLiteral(num) => {
if seen_number_values.contains(&num.value) {
ctx.diagnostic(NoDuplicateEnumValuesDiagnostic(num.span));
if let Some((_, old_span)) =
seen_number_values.iter().find(|(v, _)| *v == num.value)
{
ctx.diagnostic(NoDuplicateEnumValuesDiagnostic(*old_span, num.span));
} else {
seen_number_values.push((num.value, num.span));
}
seen_number_values.push(num.value);
}
Expression::StringLiteral(str) => {
if seen_string_values.contains(&str.value) {
ctx.diagnostic(NoDuplicateEnumValuesDiagnostic(str.span));
Expression::StringLiteral(s) => {
if let Some(old_span) = seen_string_values.insert(&s.value, s.span) {
ctx.diagnostic(NoDuplicateEnumValuesDiagnostic(old_span, s.span));
}
seen_string_values.insert(&str.value);
}
_ => {}
}

29
crates/oxc_linter/src/snapshots/no_duplicate_enum_values.snap
View file

@ -1,38 +1,49 @@
---
source: crates/oxc_linter/src/tester.rs
assertion_line: 80
expression: no_duplicate_enum_values
---
⚠ Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:3:1]
⚠ typescript-eslint(no-duplicate-enum-values): Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:2:1]
2 │ enum E {
3 │ A = 1,
· ─
4 │ B = 1,
· ─
5 │ }
╰────
help: Duplicate values can lead to bugs that are hard to track down
⚠ Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:3:1]
⚠ typescript-eslint(no-duplicate-enum-values): Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:2:1]
2 │ enum E {
3 │ A = 'A',
· ───
4 │ B = 'A',
· ───
5 │ }
╰────
help: Duplicate values can lead to bugs that are hard to track down
⚠ Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:3:1]
⚠ typescript-eslint(no-duplicate-enum-values): Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:2:1]
2 │ enum E {
3 │ A = 'A',
· ───
4 │ B = 'A',
· ───
5 │ C = 1,
╰────
help: Duplicate values can lead to bugs that are hard to track down
⚠ Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:5:1]
⚠ typescript-eslint(no-duplicate-enum-values): Disallow duplicate enum member values
╭─[no_duplicate_enum_values.tsx:4:1]
4 │ B = 'A',
5 │ C = 1,
· ─
6 │ D = 1,
· ─
7 │ }
╰────
help: Duplicate values can lead to bugs that are hard to track down