dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): update TSImportType parameter to argument (#2429)

Browse source 
In typescript it's named argument, so we should keep it consistent

64d2eeea7b/src/compiler/types.ts (L2180)
This commit is contained in:
Dunqing 2024-02-19 10:29:24 +08:00 committed by GitHub
parent 4b11183732
commit 3cbe786b18
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_ast/src/ast/ts.rs
View file

@ -776,7 +776,7 @@ pub struct TSImportType<'a> {
#[cfg_attr(feature = "serde", serde(flatten))] #[cfg_attr(feature = "serde", serde(flatten))]
pub span: Span, pub span: Span,
pub is_type_of: bool, pub is_type_of: bool,
pub parameter: TSType<'a>, pub argument: TSType<'a>,
pub qualifier: Option<TSTypeName<'a>>, pub qualifier: Option<TSTypeName<'a>>,
pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>, pub type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
} }

4
crates/oxc_ast/src/ast_builder.rs
View file

@ -1650,14 +1650,14 @@ impl<'a> AstBuilder<'a> {
&self, &self,
span: Span, span: Span,
is_type_of: bool, is_type_of: bool,
parameter: TSType<'a>, argument: TSType<'a>,
qualifier: Option<TSTypeName<'a>>, qualifier: Option<TSTypeName<'a>>,
type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>, type_parameters: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
) -> TSType<'a> { ) -> TSType<'a> {
TSType::TSImportType(self.alloc(TSImportType { TSType::TSImportType(self.alloc(TSImportType {
span, span,
is_type_of, is_type_of,
parameter, argument,
qualifier, qualifier,
type_parameters, type_parameters,
})) }))

4
crates/oxc_parser/src/ts/types.rs
View file

@ -762,7 +762,7 @@ impl<'a> ParserImpl<'a> {
let is_type_of = self.eat(Kind::Typeof); let is_type_of = self.eat(Kind::Typeof);
self.expect(Kind::Import)?; self.expect(Kind::Import)?;
self.expect(Kind::LParen)?; self.expect(Kind::LParen)?;
let parameter = self.parse_ts_type()?; let argument = self.parse_ts_type()?;
self.expect(Kind::RParen)?; self.expect(Kind::RParen)?;
let qualifier = if self.eat(Kind::Dot) { Some(self.parse_ts_type_name()?) } else { None }; let qualifier = if self.eat(Kind::Dot) { Some(self.parse_ts_type_name()?) } else { None };
@ -772,7 +772,7 @@ impl<'a> ParserImpl<'a> {
Ok(self.ast.ts_import_type( Ok(self.ast.ts_import_type(
self.end_span(span), self.end_span(span),
is_type_of, is_type_of,
parameter, argument,
qualifier, qualifier,
type_parameters, type_parameters,
)) ))