dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): false positive for filename_case where filename doesn't have a proper casing (#2032)

Browse source
This commit is contained in:
Boshen 2024-01-15 14:36:48 +08:00 committed by GitHub
parent 68606c4d6d
commit 3b40fbdbac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_linter/src/rules/unicorn/filename_case.rs
View file

@ -98,7 +98,7 @@ impl Rule for FilenameCase {
fn run_once<'a>(&self, ctx: &LintContext<'_>) {
let Some(filename) = ctx.file_path().file_stem().and_then(|s| s.to_str()) else { return };
let mut case_name = "";
let mut case_name = None;
let cases = [
(Case::Kebab, "kebab", self.kebab_case),
@ -113,11 +113,13 @@ impl Rule for FilenameCase {
if condition {
return;
}
case_name = name;
case_name.replace(name);
}
}
ctx.diagnostic(FilenameCaseDiagnostic(Span::default(), case_name));
if let Some(case_name) = case_name {
ctx.diagnostic(FilenameCaseDiagnostic(Span::default(), case_name));
}
}
}
@ -131,6 +133,7 @@ fn test() {
("", None, None, Some(PathBuf::from("foo/bar/baz/Que.tsx"))),
// should pass - camel_case, pascal_case both allowed
("", None, None, Some(PathBuf::from("foo/bar/baz/QueAbc.tsx"))),
("", None, None, Some(PathBuf::from("ansiHTML.tsx"))),
];
let fail = vec![
// should pass - by default kebab_case is not allowed