dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): shorten code in react/jsx_no_useless_fragment (#5350)

Browse source 
Shorten code. Also do the enum match first, as its cheaper than a string comparison.
This commit is contained in:
overlookmotel 2024-08-30 15:06:46 +00:00
parent f052a6d666
commit 381d9fe624
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crates/oxc_linter/src/rules/react/jsx_no_useless_fragment.rs
View file

@ -164,17 +164,13 @@ fn is_html_element(elem_name: &JSXElementName) -> bool {
fn is_jsx_fragment(elem: &JSXOpeningElement) -> bool {
match &elem.name {
JSXElementName::IdentifierReference(ident) => ident.name.as_str() == "Fragment",
JSXElementName::IdentifierReference(ident) => ident.name == "Fragment",
JSXElementName::MemberExpression(mem_expr) => {
if mem_expr.property.name.as_str() != "Fragment" {
return false;
if let JSXMemberExpressionObject::IdentifierReference(ident) = &mem_expr.object {
ident.name == "React" && mem_expr.property.name == "Fragment"
} else {
false
}
let JSXMemberExpressionObject::IdentifierReference(ident) = &mem_expr.object else {
return false;
};
return ident.name.as_str() == "React";
}
JSXElementName::NamespacedName(_) | JSXElementName::Identifier(_) => false,
}