dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(semantic): jsx reference with an incorrect node id (#2546)

Browse source 
The get kind from the node id should be `JSXIdentifier`, but now it's `JSXOpeningElement`.
This commit is contained in:
Dunqing 2024-03-01 21:07:57 +08:00 committed by GitHub
parent 34ecdd58d8
commit 37de80d9c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 25 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/oxc_linter/src/rules/import/namespace.rs
View file

@ -1,4 +1,4 @@
use oxc_ast::{ast::JSXElementName, AstKind};
use oxc_ast::AstKind;
use oxc_diagnostics::{
miette::{self, Diagnostic},
thiserror::Error,
@ -95,8 +95,10 @@ impl Rule for Namespace {
}
}
AstKind::JSXOpeningElement(element) => {
if let JSXElementName::MemberExpression(expr) = &element.name {
AstKind::JSXMemberExpressionObject(_) => {
if let Some(AstKind::JSXMemberExpression(expr)) =
ctx.nodes().parent_kind(node.id())
{
check_binding_exported(&expr.property.name, expr.property.span);
}
}

2
crates/oxc_linter/src/rules/nextjs/inline_script_id.rs
View file

@ -51,7 +51,7 @@ impl Rule for InlineScriptId {
'references_loop: for reference in
ctx.semantic().symbol_references(specifier.local.symbol_id.get().unwrap())
{
let node = ctx.nodes().get_node(reference.node_id());
let Some(node) = ctx.nodes().parent_node(reference.node_id()) else { return };
let AstKind::JSXElementName(_) = node.kind() else { continue };
let parent_node = ctx.nodes().parent_node(node.id()).unwrap();

2
crates/oxc_linter/src/rules/nextjs/no_script_component_in_head.rs
View file

@ -65,7 +65,7 @@ impl Rule for NoScriptComponentInHead {
for reference in
ctx.semantic().symbol_references(default_import.local.symbol_id.get().unwrap())
{
let node = ctx.nodes().get_node(reference.node_id());
let Some(node) = ctx.nodes().parent_node(reference.node_id()) else { return };
let AstKind::JSXElementName(_) = node.kind() else { continue };
let parent_node = ctx.nodes().parent_node(node.id()).unwrap();

2
crates/oxc_linter/src/rules/nextjs/no_title_in_document_head.rs
View file

@ -65,7 +65,7 @@ impl Rule for NoTitleInDocumentHead {
for reference in
ctx.semantic().symbol_references(default_import.local.symbol_id.get().unwrap())
{
let node = ctx.nodes().get_node(reference.node_id());
let Some(node) = ctx.nodes().parent_node(reference.node_id()) else { return };
let AstKind::JSXElementName(_) = node.kind() else { continue };
let parent_node = ctx.nodes().parent_node(node.id()).unwrap();

40
crates/oxc_semantic/src/builder.rs
View file

@ -1748,6 +1748,9 @@ impl<'a> SemanticBuilder<'a> {
AstKind::IdentifierReference(ident) => {
self.reference_identifier(ident);
}
AstKind::JSXIdentifier(ident) => {
self.reference_jsx_identifier(ident);
}
AstKind::UpdateExpression(_) => {
if self.is_not_expression_statement_parent() {
self.current_reference_flag |= ReferenceFlag::Read;
@ -1767,9 +1770,6 @@ impl<'a> SemanticBuilder<'a> {
AstKind::AssignmentTarget(_) => {
self.current_reference_flag |= ReferenceFlag::Write;
}
AstKind::JSXElementName(elem) => {
self.reference_jsx_element_name(elem);
}
AstKind::LabeledStatement(stmt) => {
self.label_builder.enter(stmt, self.current_node_id);
}
@ -1872,29 +1872,23 @@ impl<'a> SemanticBuilder<'a> {
}
}
fn reference_jsx_element_name(&mut self, elem: &JSXElementName) {
if matches!(
self.nodes.parent_kind(self.current_node_id),
Some(AstKind::JSXOpeningElement(_))
) {
if let Some(ident) = match elem {
JSXElementName::Identifier(ident)
if ident.name.chars().next().is_some_and(char::is_uppercase) =>
{
Some(ident)
fn reference_jsx_identifier(&mut self, ident: &JSXIdentifier) {
match self.nodes.parent_kind(self.current_node_id) {
Some(AstKind::JSXElementName(_)) => {
if !ident.name.chars().next().is_some_and(char::is_uppercase) {
return;
}
JSXElementName::MemberExpression(expr) => Some(expr.get_object_identifier()),
_ => None,
} {
let reference = Reference::new(
ident.span,
ident.name.to_compact_string(),
self.current_node_id,
ReferenceFlag::read(),
);
self.declare_reference(reference);
}
Some(AstKind::JSXMemberExpressionObject(_)) => {}
_ => return,
}
let reference = Reference::new(
ident.span,
ident.name.to_compact_string(),
self.current_node_id,
ReferenceFlag::read(),
);
self.declare_reference(reference);
}
fn is_not_expression_statement_parent(&self) -> bool {