From 3792b70dbd37b7ffec429e496916fbbe679bf3bd Mon Sep 17 00:00:00 2001
From: Wenzhe Wang <mysteryven@gmail.com>
Date: Mon, 29 May 2023 23:11:40 +0800
Subject: [PATCH] feat(minifier): may add space before RegExpLiteral (#397)

---
 crates/oxc_minifier/src/printer/gen.rs   |  8 ++++++++
 crates/oxc_minifier/tests/esbuild/mod.rs | 15 ++++++++++++---
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/crates/oxc_minifier/src/printer/gen.rs b/crates/oxc_minifier/src/printer/gen.rs
index 6da7c2cc5..c5c2e5098 100644
--- a/crates/oxc_minifier/src/printer/gen.rs
+++ b/crates/oxc_minifier/src/printer/gen.rs
@@ -801,6 +801,14 @@ impl Gen for BigintLiteral {
 
 impl Gen for RegExpLiteral {
     fn gen(&self, p: &mut Printer) {
+        let last = p.peek_nth(0);
+        // Avoid forming a single-line comment or "</script" sequence
+        if Some('/') == last
+            || (Some('<') == last
+                && self.regex.pattern.as_str().to_lowercase().starts_with("script"))
+        {
+            p.print(b' ');
+        }
         p.print(b'/');
         p.print_str(self.regex.pattern.as_bytes());
         p.print(b'/');
diff --git a/crates/oxc_minifier/tests/esbuild/mod.rs b/crates/oxc_minifier/tests/esbuild/mod.rs
index fd6e86d47..7811b6cdd 100644
--- a/crates/oxc_minifier/tests/esbuild/mod.rs
+++ b/crates/oxc_minifier/tests/esbuild/mod.rs
@@ -570,7 +570,7 @@ fn whitespace() {
     // test("1 + -Infinity", "1+-1/0");
     // test("1 - -Infinity", "1- -1/0;");
 
-    // test("/x/ / /y/", "/x// /y/");
+    test("/x/ / /y/", "/x// /y/");
     test("/x/ + Foo", "/x/+Foo");
     test("/x/ instanceof Foo", "/x/ instanceof Foo");
     test("[x] instanceof Foo", "[x]instanceof Foo");
@@ -693,8 +693,17 @@ fn jsx() {}
 fn jsx_single_line() {}
 
 #[test]
-#[ignore]
-fn avoid_slash_script() {}
+fn avoid_slash_script() {
+    // Positive cases
+    test("x = 1 < /script/.exec(y).length", "x=1< /script/.exec(y).length");
+    test("x = 1 < /SCRIPT/.exec(y).length", "x=1< /SCRIPT/.exec(y).length");
+    test("x = 1 < /ScRiPt/.exec(y).length", "x=1< /ScRiPt/.exec(y).length");
+    test("x = 1 << /script/.exec(y).length", "x=1<< /script/.exec(y).length");
+
+    // Negative cases
+    test("x = 1 < / script/.exec(y).length", "x=1</ script/.exec(y).length");
+    test("x = 1 << / script/.exec(y).length", "x=1<</ script/.exec(y).length");
+}
 
 #[test]
 fn binary_operator_visitor() {