From 35a0f895dcc95592a4b1e566dff807a73e35f53d Mon Sep 17 00:00:00 2001
From: keita hino <keitahino0415@gmail.com>
Date: Fri, 23 Feb 2024 16:55:28 +0900
Subject: [PATCH] fix(linter): Handle cases where createElement is an
 Identifier in is_create_element_call (#2474)

I fixed a false negative issue in the `is_create_element_call` function
where createElement was an Identifier.

https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/utils/react.rs#L13-L19

In the case of [eslint-plugin-react's button-has-type
rule](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/button-has-type.md),
the following triggers the expected errors:
```ts
// error
React.createElement("button")
// error
createElement("button")
```

However, with Oxlint, it behaves differently:
```ts
// error
React.createElement("button")
// false negative
createElement("button")
```
---
 crates/oxc_linter/src/rules/react/button_has_type.rs | 2 ++
 crates/oxc_linter/src/snapshots/button_has_type.snap | 7 +++++++
 crates/oxc_linter/src/utils/react.rs                 | 4 ++++
 3 files changed, 13 insertions(+)

diff --git a/crates/oxc_linter/src/rules/react/button_has_type.rs b/crates/oxc_linter/src/rules/react/button_has_type.rs
index 1ad7d7102..637700eef 100644
--- a/crates/oxc_linter/src/rules/react/button_has_type.rs
+++ b/crates/oxc_linter/src/rules/react/button_has_type.rs
@@ -223,6 +223,7 @@ fn test() {
         (r"<button type={condition ? 'button' : 'submit'}/>", None),
         (r"<button type={condition ? `button` : `submit`}/>", None),
         (r#"<button type="button"/>"#, Some(serde_json::json!([{ "reset": false }]))),
+        (r#"createElement("span")"#, None),
         (r#"React.createElement("span")"#, None),
         (r#"React.createElement("span", {type: "foo"})"#, None),
         (r#"React.createElement("button", {type: "button"})"#, None),
@@ -290,6 +291,7 @@ fn test() {
             r#"<button type={condition ? "reset" : "button"}/>"#,
             Some(serde_json::json!([{ "reset": false }])),
         ),
+        (r#"createElement("button")"#, None),
         (r#"React.createElement("button")"#, None),
         (r#"React.createElement("button", {type: foo})"#, None),
         (r#"React.createElement("button", {type: "foo"})"#, None),
diff --git a/crates/oxc_linter/src/snapshots/button_has_type.snap b/crates/oxc_linter/src/snapshots/button_has_type.snap
index 389b90f2c..01b884d39 100644
--- a/crates/oxc_linter/src/snapshots/button_has_type.snap
+++ b/crates/oxc_linter/src/snapshots/button_has_type.snap
@@ -108,6 +108,13 @@ expression: button_has_type
    ╰────
   help: Change the `type` attribute to one of the allowed values: `button`, `submit`, or `reset`.
 
+  ⚠ eslint-plugin-react(button-has-type): `button` elements must have an explicit `type` attribute.
+   ╭─[button_has_type.tsx:1:1]
+ 1 │ createElement("button")
+   · ───────────────────────
+   ╰────
+  help: Add a `type` attribute to the `button` element.
+
   ⚠ eslint-plugin-react(button-has-type): `button` elements must have an explicit `type` attribute.
    ╭─[button_has_type.tsx:1:1]
  1 │ React.createElement("button")
diff --git a/crates/oxc_linter/src/utils/react.rs b/crates/oxc_linter/src/utils/react.rs
index c246774ef..44488d5a4 100644
--- a/crates/oxc_linter/src/utils/react.rs
+++ b/crates/oxc_linter/src/utils/react.rs
@@ -15,6 +15,10 @@ pub fn is_create_element_call(call_expr: &CallExpression) -> bool {
         return member_expr.static_property_name() == Some("createElement");
     }
 
+    if let Some(ident) = call_expr.callee.get_identifier_reference() {
+        return ident.name == "createElement";
+    }
+
     false
 }