From 332ed81e1e83aabf55054e1a957c43888db4fba1 Mon Sep 17 00:00:00 2001 From: Shannon Rothe Date: Tue, 21 Nov 2023 21:22:09 +1100 Subject: [PATCH] chore(linter): uncomment test case for `no-func-assign` rule (#1483) --- crates/oxc_linter/src/rules/eslint/no_func_assign.rs | 3 +-- crates/oxc_linter/src/snapshots/no_func_assign.snap | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/oxc_linter/src/rules/eslint/no_func_assign.rs b/crates/oxc_linter/src/rules/eslint/no_func_assign.rs index 7c86fb16a..112761a00 100644 --- a/crates/oxc_linter/src/rules/eslint/no_func_assign.rs +++ b/crates/oxc_linter/src/rules/eslint/no_func_assign.rs @@ -73,8 +73,7 @@ fn test() { ("({x: foo = 0} = bar); function foo() { };", None), ("function foo() { [foo] = bar; }", None), ("(function() { ({x: foo = 0} = bar); function foo() { }; })();", None), - // TODO - // ("var a = function foo() { foo = 123; };", None), + ("var a = function foo() { foo = 123; };", None), ]; Tester::new(NoFuncAssign::NAME, pass, fail).test_and_snapshot(); diff --git a/crates/oxc_linter/src/snapshots/no_func_assign.snap b/crates/oxc_linter/src/snapshots/no_func_assign.snap index 01e6e9f5c..f258e721f 100644 --- a/crates/oxc_linter/src/snapshots/no_func_assign.snap +++ b/crates/oxc_linter/src/snapshots/no_func_assign.snap @@ -51,4 +51,11 @@ expression: no_func_assign · ╰── foo is re-assigned here ╰──── + ⚠ eslint(no-func-assign): 'foo' is a function. + ╭─[no_func_assign.tsx:1:1] + 1 │ var a = function foo() { foo = 123; }; + · ─┬─ + · ╰── foo is re-assigned here + ╰──── +