dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(ast_tools): ignore raw field of NumericLiteral and StringLiteral in ContentEq (#8417)

Browse source 
We use `content_eq` in the minifier, where raw value can become `None`.

`raw` cannot be removed from other literals, they will always be equal otherwise.
This commit is contained in:
Boshen 2025-01-10 14:43:07 +00:00
parent 357b61d179
commit 3212bcdaee
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/oxc_ast/src/generated/derive_content_eq.rs
View file

@ -30,7 +30,6 @@ impl ContentEq for NullLiteral {
impl ContentEq for NumericLiteral<'_> {
fn content_eq(&self, other: &Self) -> bool {
ContentEq::content_eq(&self.value, &other.value)
&& ContentEq::content_eq(&self.raw, &other.raw)
&& ContentEq::content_eq(&self.base, &other.base)
}
}
@ -38,7 +37,6 @@ impl ContentEq for NumericLiteral<'_> {
impl ContentEq for StringLiteral<'_> {
fn content_eq(&self, other: &Self) -> bool {
ContentEq::content_eq(&self.value, &other.value)
&& ContentEq::content_eq(&self.raw, &other.raw)
}
}

4
tasks/ast_tools/src/derives/content_eq.rs
View file

@ -87,6 +87,10 @@ fn derive_struct(def: &StructDef) -> (&str, TokenStream) {
.iter()
.filter(|field| {
let Some(name) = field.name.as_ref() else { return false };
if name == "raw" && matches!(def.name.as_str(), "NumericLiteral" | "StringLiteral")
{
return false;
}
!IGNORE_FIELDS
.iter()
.any(|it| name == it.0 && field.typ.name().inner_name() == it.1)