dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-20 04:38:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(parser): remove erroneous debug assertion (#2356)

Browse source 
This was a bit of a whoopsie in last batch of PRs. This assertion shouldn't be there, because all reads are now via `source.position().read()`, so this assertion says "you can only read some byte values".

Only reason it didn't blow up conformance tests is that they run in release mode.

Sorry. Please merge soon as you can and cover my shame!
This commit is contained in:
overlookmotel 2024-02-09 12:55:12 +00:00 committed by GitHub
parent 2eb489e996
commit 2f6cf73d51
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/oxc_parser/src/lexer/source.rs
View file

@ -162,22 +162,7 @@ impl<'a> Source<'a> {
pub(super) fn position(&self) -> SourcePosition<'a> {
// SAFETY: Creating a `SourcePosition` from current position of `Source` is always valid,
// if caller has upheld safety conditions of other unsafe methods of this type.
let pos = unsafe { SourcePosition::new(self.ptr) };
// SAFETY: `pos.read()`'s contract is upheld by:
// * The preceding checks that `pos.ptr` >= `self.start` and < `self.end`.
// * `Source`'s invariants guarantee that `self.start` - `self.end` contains allocated memory.
// * `Source::new` takes an immutable ref `&str`, guaranteeing that the memory `pos.ptr`
// addresses cannot be aliased by a `&mut` ref as long as `Source` exists.
// * `SourcePosition` can only live as long as the `&str` underlying `Source`.
debug_assert!(
pos.ptr >= self.start
&& pos.ptr <= self.end
// SAFETY: See above
&& (pos.ptr == self.end || !is_utf8_cont_byte(unsafe { pos.read() }))
);
pos
unsafe { SourcePosition::new(self.ptr) }
}
/// Move current position.