dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): react/jsx_no_undef rule get_member_ident do not return Option (#5411)

Browse source 
Small tidy-up after #5358. `get_member_ident` now always returns a value, never `None`, so no need for it to return an `Option`.
This commit is contained in:
overlookmotel 2024-09-02 18:42:02 +00:00
parent 1aa49af010
commit 2ccbd9361b
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/oxc_linter/src/rules/react/jsx_no_undef.rs
View file

@ -37,14 +37,14 @@ fn get_resolvable_ident<'a>(node: &'a JSXElementName<'a>) -> Option<&'a Identifi
match node {
JSXElementName::Identifier(_) | JSXElementName::NamespacedName(_) => None,
JSXElementName::IdentifierReference(ref ident) => Some(ident),
JSXElementName::MemberExpression(expr) => get_member_ident(expr),
JSXElementName::MemberExpression(expr) => Some(get_member_ident(expr)),
}
}
fn get_member_ident<'a>(mut expr: &'a JSXMemberExpression<'a>) -> Option<&'a IdentifierReference> {
fn get_member_ident<'a>(mut expr: &'a JSXMemberExpression<'a>) -> &'a IdentifierReference {
loop {
match &expr.object {
JSXMemberExpressionObject::IdentifierReference(ident) => return Some(ident),
JSXMemberExpressionObject::IdentifierReference(ident) => return ident,
JSXMemberExpressionObject::MemberExpression(next_expr) => {
expr = next_expr;
}