dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter/no-unused-vars): false positives when variable and type have same name (#8465)

Browse source 
close: #8236
This commit is contained in:
Dunqing 2025-01-13 15:40:48 +00:00
parent 1d6e84dd33
commit 2be1e82964
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs
View file

@ -1083,7 +1083,10 @@ fn test_namespaces() {
#[test]
fn test_type_aliases() {
let pass = vec!["type Foo = string; export default Foo;"];
let pass = vec![
"type Foo = string; export default Foo;",
"const a = { hello: 'world' }; export type a = typeof a;",
];
let fail = vec![
// usages within own declaration do not count

4
crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
View file

@ -291,7 +291,9 @@ impl<'a> Symbol<'_, 'a> {
| AstKind::ExportNamedDeclaration(_)
| AstKind::ExportDefaultDeclaration(_)
| AstKind::ExportAllDeclaration(_)
| AstKind::Program(_) => {
| AstKind::Program(_)
// It refers to value bindings, not types
| AstKind::TSTypeQuery(_) => {
return false;
}