dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fix configuration casing for typescript/no_this_alias (#7836)

Browse source 
closes #7835
This commit is contained in:
Boshen 2024-12-13 19:39:59 +08:00 committed by GitHub
parent 5b7e1adc9b
commit 2b187e59ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
crates/oxc_linter/src/rules/typescript/no_this_alias.rs
View file

@ -81,7 +81,7 @@ impl Rule for NoThisAlias {
let obj = value.get(0);
let allowed_names: FxHashSet<CompactStr> = value
.get(0)
.and_then(|v| v.get("allow_names"))
.and_then(|v| v.get("allowNames"))
.and_then(Value::as_array)
.unwrap_or(&vec![])
.iter()
@ -91,7 +91,7 @@ impl Rule for NoThisAlias {
Self(Box::new(NoThisAliasConfig {
allow_destructuring: obj
.and_then(|v| v.get("allow_destructuring"))
.and_then(|v| v.get("allowDestructuring"))
.and_then(Value::as_bool)
.unwrap_or_default(),
allow_names: allowed_names,
@ -175,28 +175,28 @@ fn test() {
// allow destructuring
(
"const { props, state } = this;",
Some(serde_json::json!([{ "allow_destructuring": true }])),
Some(serde_json::json!([{ "allowDestructuring": true }])),
),
("const { length } = this;", Some(serde_json::json!([{ "allow_destructuring": true }]))),
("const { length } = this;", Some(serde_json::json!([{ "allowDestructuring": true }]))),
(
"const { length, toString } = this;",
Some(serde_json::json!([{ "allow_destructuring": true }])),
Some(serde_json::json!([{ "allowDestructuring": true }])),
),
("const [foo] = this;", Some(serde_json::json!([{ "allow_destructuring": true }]))),
("const [foo, bar] = this;", Some(serde_json::json!([{ "allow_destructuring": true }]))),
("const [foo] = this;", Some(serde_json::json!([{ "allowDestructuring": true }]))),
("const [foo, bar] = this;", Some(serde_json::json!([{ "allowDestructuring": true }]))),
// allow list
("const self = this;", Some(serde_json::json!([{ "allow_names": vec!["self"] }]))),
("const self = this;", Some(serde_json::json!([{ "allowNames": vec!["self"] }]))),
];
let fail = vec![
("const self = this;", None),
(
"const { props, state } = this;",
Some(serde_json::json!([{ "allow_destructuring": false }])),
Some(serde_json::json!([{ "allowDestructuring": false }])),
),
(
"const [ props, state ] = this;",
Some(serde_json::json!([{ "allow_destructuring": false }])),
Some(serde_json::json!([{ "allowDestructuring": false }])),
),
("let foo; \nconst other =3;\n\n\n\nfoo = this", None),
("let foo; (foo as any) = this", None),
@ -232,7 +232,7 @@ fn test() {
const [foo, bar] = this;
}
}",
Some(serde_json::json!([{ "allow_destructuring": false }])),
Some(serde_json::json!([{ "allowDestructuring": false }])),
),
];