dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): overflow in no-obj-calls (#4397)

Browse source 
Closes #4389
This commit is contained in:
DonIsaac 2024-07-21 23:35:47 +00:00
parent c294833b12
commit 289dc39865
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_linter/src/rules/eslint/no_obj_calls.rs
View file

@ -87,12 +87,15 @@ fn resolve_global_binding<'a, 'b: 'a>(
let nodes = ctx.nodes(); let nodes = ctx.nodes();
let symbols = ctx.symbols(); let symbols = ctx.symbols();
scope.ancestors(scope_id).find_map(|id| scope.get_binding(id, &ident.name)).map_or_else( scope.ancestors(scope_id).find_map(|id| scope.get_binding(id, &ident.name)).map_or_else(
// panic in debug builds, but fail gracefully in release builds
|| { || {
panic!( debug_assert!(
false,
"No binding id found for {}, but this IdentifierReference "No binding id found for {}, but this IdentifierReference
is not a global", is not a global",
&ident.name &ident.name
); );
None
}, },
|binding_id| { |binding_id| {
let decl = nodes.get_node(symbols.get_declaration(binding_id)); let decl = nodes.get_node(symbols.get_declaration(binding_id));
@ -104,7 +107,9 @@ fn resolve_global_binding<'a, 'b: 'a>(
} }
match &parent_decl.init { match &parent_decl.init {
// handles "let a = JSON; let b = a; a();" // handles "let a = JSON; let b = a; a();"
Some(Expression::Identifier(parent_ident)) => { Some(Expression::Identifier(parent_ident))
if parent_ident.name != ident.name =>
{
resolve_global_binding(parent_ident, decl_scope, ctx) resolve_global_binding(parent_ident, decl_scope, ctx)
} }
// handles "let a = globalThis.JSON; let b = a; a();" // handles "let a = globalThis.JSON; let b = a; a();"
@ -180,6 +185,13 @@ fn test() {
// https://github.com/oxc-project/oxc/pull/508#issuecomment-1618850742 // https://github.com/oxc-project/oxc/pull/508#issuecomment-1618850742
("{const Math = () => {}; {let obj = new Math();}}", None), ("{const Math = () => {}; {let obj = new Math();}}", None),
("{const {parse} = JSON;parse('{}')}", None), ("{const {parse} = JSON;parse('{}')}", None),
// https://github.com/oxc-project/oxc/issues/4389
(
r"
export const getConfig = getConfig;
getConfig();",
None,
),
]; ];
let fail = vec![ let fail = vec![