dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(codegen): print readonly keyword for TSIndexSignature (#3791)

Browse source
This commit is contained in:
Dunqing 2024-06-20 10:13:50 +00:00
parent 7d47fc3fcc
commit 2821e0e307
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/oxc_codegen/src/gen.rs
View file

@ -3025,8 +3025,7 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for TSSignature<'a> {
Self::TSIndexSignature(signature) => signature.gen(p, ctx), Self::TSIndexSignature(signature) => signature.gen(p, ctx),
Self::TSPropertySignature(signature) => { Self::TSPropertySignature(signature) => {
if signature.readonly { if signature.readonly {
p.print_str(b"readonly"); p.print_str(b"readonly ");
p.print_hard_space();
} }
if signature.computed { if signature.computed {
p.print(b'['); p.print(b'[');
@ -3191,6 +3190,9 @@ impl<'a, const MINIFY: bool> Gen<MINIFY> for TSTypeParameterInstantiation<'a> {
impl<'a, const MINIFY: bool> Gen<MINIFY> for TSIndexSignature<'a> { impl<'a, const MINIFY: bool> Gen<MINIFY> for TSIndexSignature<'a> {
fn gen(&self, p: &mut Codegen<{ MINIFY }>, ctx: Context) { fn gen(&self, p: &mut Codegen<{ MINIFY }>, ctx: Context) {
if self.readonly {
p.print_str(b"readonly ");
}
p.print_str(b"["); p.print_str(b"[");
for (index, parameter) in self.parameters.iter().enumerate() { for (index, parameter) in self.parameters.iter().enumerate() {
if index != 0 { if index != 0 {

4
crates/oxc_isolated_declarations/tests/fixtures/readonly.ts vendored Normal file
View file

@ -0,0 +1,4 @@
export const EMPTY_OBJ: { readonly [key: string]: any } = __DEV__
? Object.freeze({})
: {}
export const EMPTY_ARR: readonly never[] = __DEV__ ? Object.freeze([]) : []

8
crates/oxc_isolated_declarations/tests/snapshots/readonly.snap Normal file
View file

@ -0,0 +1,8 @@
---
source: crates/oxc_isolated_declarations/tests/mod.rs
input_file: crates/oxc_isolated_declarations/tests/fixtures/readonly.ts
---
==================== .D.TS ====================
export declare const EMPTY_OBJ: {readonly [key: string]: any};
export declare const EMPTY_ARR: readonly (never)[];