dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(syntax): ASCII tables static not const (#2128)

Browse source 
A small nit: `ASCII_CONTINUE` is used in multiple places, so it's
preferable that it's a `static` not a `const` so it only gets included
in the binary once, rather than once for each usage.

Only makes a tiny difference on benchmarks (~0.1 ms), but change seems
worthwhile anyway just to be more "good practice".
This commit is contained in:
overlookmotel 2024-01-22 13:49:54 +00:00 committed by GitHub
parent 3ef631807d
commit 27aaff2bef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_syntax/src/identifier.rs
View file

@ -71,7 +71,7 @@ pub struct Align64<T>(pub(crate) T);
// `a`-`z`, `A`-`Z`, `$` (0x24), `_` (0x5F)
#[rustfmt::skip]
pub const ASCII_START: Align64<[bool; 128]> = Align64([
pub static ASCII_START: Align64<[bool; 128]> = Align64([
// 0 1 2 3 4 5 6 7 8 9 A B C D E F //
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 0
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 1
@ -85,7 +85,7 @@ pub const ASCII_START: Align64<[bool; 128]> = Align64([
// `ASCII_START` + `0`-`9`
#[rustfmt::skip]
pub const ASCII_CONTINUE: Align64<[bool; 128]> = Align64([
pub static ASCII_CONTINUE: Align64<[bool; 128]> = Align64([
// 0 1 2 3 4 5 6 7 8 9 A B C D E F //
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 0
__, __, __, __, __, __, __, __, __, __, __, __, __, __, __, __, // 1