From 25d6e20bbaee265cf0d4bfccf3ded25e0670cf73 Mon Sep 17 00:00:00 2001 From: overlookmotel <557937+overlookmotel@users.noreply.github.com> Date: Fri, 23 Aug 2024 12:49:32 +0000 Subject: [PATCH] fix(traverse): add missing visitors to `ChildScopeCollector` (#5118) `ChildScopeCollector` was missing visitors for a few nodes which have recently had scopes added to them. --- crates/oxc_traverse/src/context/scoping.rs | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/crates/oxc_traverse/src/context/scoping.rs b/crates/oxc_traverse/src/context/scoping.rs index 459f53e5e..691eab2d1 100644 --- a/crates/oxc_traverse/src/context/scoping.rs +++ b/crates/oxc_traverse/src/context/scoping.rs @@ -535,6 +535,11 @@ impl ChildScopeCollector { } impl<'a> Visit<'a> for ChildScopeCollector { + #[inline] + fn visit_program(&mut self, program: &Program<'a>) { + self.add_scope(&program.scope_id); + } + #[inline] fn visit_block_statement(&mut self, stmt: &BlockStatement<'a>) { self.add_scope(&stmt.scope_id); @@ -614,4 +619,22 @@ impl<'a> Visit<'a> for ChildScopeCollector { fn visit_ts_conditional_type(&mut self, it: &TSConditionalType<'a>) { self.add_scope(&it.scope_id); } + + #[inline] + fn visit_ts_type_alias_declaration(&mut self, it: &TSTypeAliasDeclaration<'a>) { + self.add_scope(&it.scope_id); + } + + #[inline] + fn visit_ts_method_signature(&mut self, it: &TSMethodSignature<'a>) { + self.add_scope(&it.scope_id); + } + + #[inline] + fn visit_ts_construct_signature_declaration( + &mut self, + it: &TSConstructSignatureDeclaration<'a>, + ) { + self.add_scope(&it.scope_id); + } }